Skip to content

Improve/create appimage 2026 08 04 - #9

Merged
pedrolcl merged 3 commits into
develfrom
improve/create-appimage-2026-08-04
Aug 5, 2026
Merged

Improve/create appimage 2026 08 04#9
pedrolcl merged 3 commits into
develfrom
improve/create-appimage-2026-08-04

Conversation

@pedrolcl

@pedrolcl pedrolcl commented Aug 4, 2026

Copy link
Copy Markdown
Owner
  • Validate required args and paths, use portable arch check
  • Allow passing APPIMAGETOOL_PATH / APPIMAGETOOL_VERSION
  • Safer quoting of paths, better error messages, and capture appimagetool output on failure
  • Place output AppImage in WORKDIR and prefer relative symlinks inside AppDir
  • Add usage docs and example in the file header

@pedrolcl

pedrolcl commented Aug 5, 2026

Copy link
Copy Markdown
Owner Author

Problems:

  • There is no license, it should be on line 2: "# SPDX-License-Identifier: BSD-3-Clause".
  • There is no indication of the minimum cmake version. Should have: "cmake_minimum_required(VERSION 3.16)".
  • There is no validation of unparsed arguments. Should have something like:
    if(ARGS_UNPARSED_ARGUMENTS)
        message(FATAL_ERROR ""CREATE_APPIMAGE: unparsed arguments ${ARGS_UNPARSED_ARGUMENTS}")
    endif()
  • Comment about using the CPack AppImage generator in CMake >= 4.2 instead of this function.
  • Unrelated to this function. The AppImage does not include both xcb and wayland platform plugins:
    in main CMakeLists.txt: qt_generate_deploy_app_script() should have a INCLUDE_PLUGINS argument (Linux).

@pedrolcl
pedrolcl merged commit a94034a into devel Aug 5, 2026
8 checks passed
@pedrolcl
pedrolcl deleted the improve/create-appimage-2026-08-04 branch August 6, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant