Repository navigation
Conversation
0xkkonrad
added a commit
that referenced
this pull request
Nov 15, 2026
… Android back check The handoff did not say that store.ios in app-config.json stays a placeholder until someone fills it, and device check 10 still described Android back before the rooms-list fix.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server parts the Peanut Split iOS and Android apps need on production before the first store build is useful. Draft. Do not merge before Konrad and Hugo review it.
The branch is rebuilt by
local/split-native-app/tools/server-prep.sh(mono, not in this repo) fromorigin/mainplus a fixed allowlist taken fromnative-apps(draft PR #37). The script never auto-includes a file: it fails, naming the file, if an allowlisted file imports anything that is neither onmainnor on the list.docs/current/generated/*.mdare regenerated on this branch, not copied.Contents, and why each is inert for web users
src/lib/cors.ts+src/proxy.ts(+ tests): CORS forcapacitor://localhostandhttps://localhoston/api/*Originor none, socorsForreturnsnulland the response is unchanged. Any other origin still gets noAccess-Control-Allow-Origin. Redirects (alias hosts) are untouched.src/proxy.ts: internalx-split-room-slugrequest header on/r/<slug>pages, stripped from caller requestsmainnothing reads it (the Smart App Banner layout reader stays onnative-apps). The proxy deletes any caller-supplied copy, so no route can be handed a forged one.public/.well-known/apple-app-site-association(appIDPW388G893L.com.peanutsplit.app) +headers()rule serving it asapplication/jsonsrc/lib/splash.test.ts: records.well-known/as an online-onlypublic/folderpublic/.well-known/assetlinks.json(placeholder fingerprint)public/app-config.json+headers()rule (ACAO: *, 5 min cache)minBuildis 0 for both platforms.next.config.js:env: { NEXT_PUBLIC_NATIVE_BUILD: '0' }'0'in the web build. No code onmainreads it yet.PushSubscription.transport(defaultwebpush),p256dh/authnullable; migration20261114011233_push_transportwebpushand keep their keys.src/server/push.ts,src/server/push-native/**,notifyCopy.ts,pushHosts.ts,validation.ts, push-subscriptions routes (+server/test/push.test.ts){ transport, token }) gets503 NATIVE_PUSH_UNAVAILABLEuntil the APNs/FCM secrets exist; no secret is set by this PR.src/lib/api-types.ts(push input union),src/lib/error-messages.ts+errors.NATIVE_PUSH_UNAVAILABLEin the 7 catalogssrc/lib/redact.ts(+ test): also redacts?slug=src/lib/analytics.ts: 4AnalyticsEventunion entries;JoinGate.tsxfiresjoin_gate_shown/join_gate_completed { via }roomProps(slug)only, never a slug or name). No UI change.src/app/(product-shell)/privacy/page.tsxNot included on purpose: no client guards (
caches, install handoff). Browsers onmainalways havecaches; those guards reachmainwith thenative-appsmerge.Review
appIDsisPW388G893L.com.peanutsplit.app(the team that ships the Peanut app). If the team differs, change that one line before merging.Deploy checks (after merge and deploy)
curl -si -X OPTIONS -H 'Origin: capacitor://localhost' -H 'Access-Control-Request-Method: GET' https://peanutsplit.com/api/currenciesreturns204withAccess-Control-Allow-Origin: capacitor://localhost.curl -si https://peanutsplit.com/.well-known/apple-app-site-associationreturns200withContent-Type: application/jsonand no redirect.gh run rerun <latest native.yml run id on native-apps>; the Android emulator smoke log printsSPLIT_CORS ok(it printsblockeduntil this is live).Verified on the branch
format:check,docs:check,i18n:audit,marketing-copy:audit,ui-icons:audit,licenses:checkandpnpm build(with the PWA build-boundary check): green.server/test/push.test.ts, route handlers) run inci.yml.🤖 Generated with Claude Code