Skip to content

fix(TASK-25015): signup names Argentina's ARS funding row Mercado Pago, with its mark - #4117

Merged
abalinda merged 1 commit into
devfrom
fix/TASK-25015-ar-mercado-pago-funding-row
Nov 16, 2026
Merged

abalinda merged 1 commit into
devfrom
fix/TASK-25015-ar-mercado-pago-funding-row

Conversation

@abalinda

@abalinda abalinda commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

In the signup "Add money with" sheet, a resident of Argentina saw Bank transfer (ARS) with a green bank bubble. Argentines add ARS from Mercado Pago, so the row now reads Mercado Pago (ARS) in every locale and leads with the Mercado Pago mark. After the pick, the button reads Mercado Pago with the mark at the 24 px slot.

This mirrors the Pix (BRL) change for Brazil (TASK-24947):

  • CONCEPT_ICONS gains mercadoPago: { logo: MERCADO_PAGO }, a brand mark next to Pix (the whole circle, no bubble).
  • SETUP_CHANNEL_CONCEPTS.arsBank maps to it.
  • New key addMoney.methods.mercadoPago for the button label; setup.paymentPlan.funding.arsBank becomes "Mercado Pago (ARS)". Both are allowlisted as brand name + currency code.
  • The stored value stays arsBank: the saved plan and the analytics are data.

Context: the 2026-11-16 WAU war room named funding as the biggest funnel drop for Argentinians.

Task

TASK-25015

Risks

  • Label and icon only. No API, data or route change. No backend change needed.
  • The concept-map comment and the /dev/ds icon-bubble note now say Pix and Mercado Pago are the brand marks (they said only Pix).

QA

  • PaymentPlan.test.tsx: the Argentina case now asserts the row label, the logo (no bubble) at 32 px in the drawer and 24 px on the button, the "Mercado Pago" button label, and that arsBank is still saved.
  • Local gate: prettier, typecheck, npm test (1,451/1,452 suites; the one failure is the known Node 26 QRScanner test, which passes on CI Node 22), screen-wordiness --check clean.
  • Screenshots: the ds-shots diff of 03-j-funding-methods-argentina (fixture setup-payment-plan) on this PR.

🤖 Generated with Claude Code

…o, with its mark

Argentines add ARS from Mercado Pago, so "Bank transfer (ARS)" with a green
bank bubble named the wrong method at signup. The arsBank row now reads
"Mercado Pago (ARS)" in every locale and leads with the Mercado Pago mark;
the picker button reads "Mercado Pago" with the mark at the 24 px slot.

This mirrors the Pix (BRL) change for Brazil (TASK-24947): Mercado Pago
joins Pix as a brand mark in CONCEPT_ICONS (a logo, the whole circle, no
bubble), and the setup channel maps to it. The stored value stays arsBank:
the saved plan and the analytics are data.
@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
peanut-wallet Ready Ready Preview Nov 16, 2026 2:50pm UTC

Request Review

@notion-workspace

Copy link
Copy Markdown

@abalinda

Copy link
Copy Markdown
Contributor Author

/chip review

@github-actions

Copy link
Copy Markdown
Contributor

Code-analysis diff

Painscore total: 11101.31 → 11101.2 (-0.11)
Findings: 0 net (+17 new, -17 resolved)

🆕 New findings (17)

  • critical complexity — src/dev/surfaces/registry.tsx — CC 202, MI 66.51, SLOC 960
  • critical complexity — src/components/Profile/views/ResidenceChangeDrawer.tsx — CC 58, MI 56.91, SLOC 139
  • critical complexity — src/dev/surfaces/list.ts — CC 2, MI 23.32, SLOC 573
  • high hotspot — src/dev/surfaces/registry.tsx — 121 commits, +2454/-720 lines since 6 months ago
  • high hotspot — src/dev/surfaces/list.ts — 79 commits, +784/-175 lines since 6 months ago
  • high complexity — src/components/Setup/Views/PaymentPlan.tsx — CC 46, MI 61.43, SLOC 134
  • high complexity — src/components/0_Bruddle/conceptIcons.tsx — CC 1, MI 43.72, SLOC 62
  • medium high-mdd — src/components/Profile/views/ResidenceChangeDrawer.tsx:59 — ResidenceChangeDrawer: MDD 93.9 (uses across many lines from declarations)
  • medium high-mdd — src/components/Profile/components/ResidenceMenuItem.tsx:25 — ResidenceMenuItem: MDD 46.5 (uses across many lines from declarations)
  • medium high-mdd — src/components/Setup/Views/PaymentPlan.tsx:114 — PaymentPlanStep: MDD 44.1 (uses across many lines from declarations)
  • medium high-dlt — src/components/Profile/views/ResidenceChangeDrawer.tsx:59 — ResidenceChangeDrawer: DLT 31 (calls 31 distinct functions — high context load)
  • medium method-complexity — src/components/Profile/views/ResidenceChangeDrawer.tsx:59 — CC 29 SLOC 66
  • medium complexity — src/features/setup/paymentChannels.ts — CC 27, MI 57.22, SLOC 32
  • medium complexity — src/components/Profile/components/ResidenceMenuItem.tsx — CC 25, MI 64.15, SLOC 107
  • medium method-complexity — src/features/setup/paymentChannels.ts:21 — setupChannelsForResidence CC 23 SLOC 17
  • medium react-effect-derives-state — src/components/Profile/views/ResidenceChangeDrawer.tsx:86 — small useEffect that only sets state from deps
  • low high-mdd — src/components/Profile/views/ResidenceChangeDrawer.tsx:108 — save: MDD 14.8 (uses across many lines from declarations)

✅ Resolved (17)

  • src/dev/surfaces/registry.tsx — CC 203, MI 66.51, SLOC 964
  • src/components/Profile/views/ResidenceChangeDrawer.tsx — CC 59, MI 56.81, SLOC 140
  • src/dev/surfaces/list.ts — CC 2, MI 23.24, SLOC 577
  • src/dev/surfaces/registry.tsx — 122 commits, +2472/-720 lines since 6 months ago
  • src/dev/surfaces/list.ts — 80 commits, +789/-175 lines since 6 months ago
  • src/components/Setup/Views/PaymentPlan.tsx — CC 46, MI 61.5, SLOC 133
  • src/components/Profile/views/ResidenceChangeDrawer.tsx:61 — CC 30 SLOC 67
  • src/components/0_Bruddle/conceptIcons.tsx — CC 1, MI 44.08, SLOC 60
  • src/components/Profile/views/ResidenceChangeDrawer.tsx:61 — ResidenceChangeDrawer: MDD 94.5 (uses across many lines from declarations)
  • src/components/Profile/components/ResidenceMenuItem.tsx:25 — ResidenceMenuItem: MDD 46.9 (uses across many lines from declarations)
  • src/components/Setup/Views/PaymentPlan.tsx:114 — PaymentPlanStep: MDD 43.0 (uses across many lines from declarations)
  • src/components/Profile/views/ResidenceChangeDrawer.tsx:61 — ResidenceChangeDrawer: DLT 31 (calls 31 distinct functions — high context load)
  • src/features/setup/paymentChannels.ts — CC 27, MI 57.19, SLOC 32
  • src/components/Profile/components/ResidenceMenuItem.tsx — CC 25, MI 64.1, SLOC 107
  • src/features/setup/paymentChannels.ts:20 — setupChannelsForResidence CC 23 SLOC 17
  • src/components/Profile/views/ResidenceChangeDrawer.tsx:89 — small useEffect that only sets state from deps
  • src/components/Profile/views/ResidenceChangeDrawer.tsx:111 — save: MDD 14.8 (uses across many lines from declarations)

@chip-peanut-bot chip-peanut-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chip review — no blocking findings — this is not an approval

One major copy finding: the Argentina funding option hides the bank-transfer path.

Findings

  • MAJOR · src/i18n/app/messages/es-AR.json:773 · Argentina funding choice should include bank transfers
    For an Argentine resident funding from their own bank rather than Mercado Pago, this signup row now reads only “Mercado Pago (ARS)” even though arsBank still selects the same ARS rail that accepts either source. The Add money screen deliberately calls its one route “Mercado Pago or Bank”; a bank-only user can therefore miss the valid signup choice. Keep Mercado Pago first, but name both sources in the row and its accessible label across locales; use a compact button label that remains accurate.

Checked clean

  • Exact head and merge base verified; signup channel mapping and unchanged arsBank persistence checked.
  • Argentina Add money route and canonical product documentation confirm one ARS path accepts Mercado Pago or bank transfers.
  • Design system permits a method logo in the leading slot; no icon-rule violation found.
  • At review time, typecheck, lint, format, screen-wordiness, and ds-lint passed; unit and i18n-overflow checks were still running.

Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.

Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.

Copy check by claude-haiku-5-5: 0 finding(s), titled "Copy now wrong". Every quoted passage was checked against the file.

Exact head: 1bec4f72f77c · Context: repo, product, design, lexicon · Took 3m

Comment thread src/i18n/app/messages/es-AR.json Resolved
@github-actions

Copy link
Copy Markdown
Contributor

🧪 UI test report — ✅ all green

Suites

  • ✅ unit: 21949 ran, 0 failed, 0 skipped, 11.0m

📊 Coverage (unit)

metric %
statements 88.6%
branches 81.9%
functions 82.8%
lines 90.1%
⏱ 10 slowest test cases
time test
🐢 31.4s scripts/__tests__/screens-adapter.test.js › runs the existing synthetic screen adapter Node acceptance suite
🐢 19.6s src/features/deposit-accounts/__tests__/AddMoneyArgentinaCountry.acceptance.test.tsx › keeps unavailable Argentina searchable and opens its residence explanation with Enter
🐢 18.7s src/features/deposit-accounts/__tests__/AddMoneyArgentinaCountry.acceptance.test.tsx › keeps unavailable Argentina searchable and opens its residence explanation with pointer
🐢 18.4s src/features/deposit-accounts/__tests__/AddMoneyArgentinaCountry.acceptance.test.tsx › keeps unavailable Argentina searchable and opens its residence explanation with Space
🐢 10.4s src/features/deposit-accounts/__tests__/AddMoneyArgentinaCountry.acceptance.test.tsx › preserves ordinary Argentina selection for residence AR
🐢 10.3s src/features/deposit-accounts/__tests__/AddMoneyArgentinaCountry.acceptance.test.tsx › preserves ordinary Argentina selection for residence null
🐢 9.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › Network failure keeps loading while retries remain, then shows the generic error
🐢 7.3s scripts/__tests__/signup-attribution-paths.test.ts › includes newly published articles and locale fallbacks without editing the manifest
🐢 7.3s scripts/__tests__/indexable-urls.test.ts › excludes missing locale files, drafts, redirects, and retired pages from crawl and submission lists
4.2s src/components/Setup/Views/__tests__/Residence.test.tsx › reports each picker opening, the country picked, a search that found nothing and a dismissal
📍 Inline annotations are in the **Unit test report** check above. Coverage artifact: `coverage-unit`. Generated by `.github/workflows/tests.yml`.

@abalinda
abalinda marked this pull request as ready for review November 16, 2026 15:36
Copilot AI balanced review requested due to automatic review settings November 16, 2026 15:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@abalinda
abalinda merged commit 78c0090 into dev Nov 16, 2026
53 of 54 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

English

Open screen library dashboard

After merge: 82314be → 78c0090. Reviewable capture in English; newly registered states are marked in the report.

Before was captured with the base branch's own synthetic API because this PR changes it; differences can include synthetic-data changes.

This branch was successfully deployed

1 active deployment
Preview — 1bec4f72 Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants