Repository navigation
fix(TASK-25015): signup names Argentina's ARS funding row Mercado Pago, with its mark - #4117
Conversation
…o, with its mark Argentines add ARS from Mercado Pago, so "Bank transfer (ARS)" with a green bank bubble named the wrong method at signup. The arsBank row now reads "Mercado Pago (ARS)" in every locale and leads with the Mercado Pago mark; the picker button reads "Mercado Pago" with the mark at the 24 px slot. This mirrors the Pix (BRL) change for Brazil (TASK-24947): Mercado Pago joins Pix as a brand mark in CONCEPT_ICONS (a logo, the whole circle, no bubble), and the setup channel maps to it. The stored value stays arsBank: the saved plan and the analytics are data.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
/chip review |
Code-analysis diffPainscore total: 11101.31 → 11101.2 (-0.11) 🆕 New findings (17)
✅ Resolved (17)
|
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
One major copy finding: the Argentina funding option hides the bank-transfer path.
Findings
- MAJOR · src/i18n/app/messages/es-AR.json:773 · Argentina funding choice should include bank transfers
For an Argentine resident funding from their own bank rather than Mercado Pago, this signup row now reads only “Mercado Pago (ARS)” even thougharsBankstill selects the same ARS rail that accepts either source. The Add money screen deliberately calls its one route “Mercado Pago or Bank”; a bank-only user can therefore miss the valid signup choice. Keep Mercado Pago first, but name both sources in the row and its accessible label across locales; use a compact button label that remains accurate.
Checked clean
- Exact head and merge base verified; signup channel mapping and unchanged arsBank persistence checked.
- Argentina Add money route and canonical product documentation confirm one ARS path accepts Mercado Pago or bank transfers.
- Design system permits a method logo in the leading slot; no icon-rule violation found.
- At review time, typecheck, lint, format, screen-wordiness, and ds-lint passed; unit and i18n-overflow checks were still running.
Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.
Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.
Copy check by claude-haiku-5-5: 0 finding(s), titled "Copy now wrong". Every quoted passage was checked against the file.
Exact head: 1bec4f72f77c · Context: repo, product, design, lexicon · Took 3m
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
Summary
In the signup "Add money with" sheet, a resident of Argentina saw Bank transfer (ARS) with a green bank bubble. Argentines add ARS from Mercado Pago, so the row now reads Mercado Pago (ARS) in every locale and leads with the Mercado Pago mark. After the pick, the button reads Mercado Pago with the mark at the 24 px slot.
This mirrors the Pix (BRL) change for Brazil (TASK-24947):
CONCEPT_ICONSgainsmercadoPago: { logo: MERCADO_PAGO }, a brand mark next to Pix (the whole circle, no bubble).SETUP_CHANNEL_CONCEPTS.arsBankmaps to it.addMoney.methods.mercadoPagofor the button label;setup.paymentPlan.funding.arsBankbecomes "Mercado Pago (ARS)". Both are allowlisted as brand name + currency code.arsBank: the saved plan and the analytics are data.Context: the 2026-11-16 WAU war room named funding as the biggest funnel drop for Argentinians.
Task
TASK-25015
Risks
/dev/dsicon-bubble note now say Pix and Mercado Pago are the brand marks (they said only Pix).QA
PaymentPlan.test.tsx: the Argentina case now asserts the row label, the logo (no bubble) at 32 px in the drawer and 24 px on the button, the "Mercado Pago" button label, and thatarsBankis still saved.npm test(1,451/1,452 suites; the one failure is the known Node 26QRScannertest, which passes on CI Node 22),screen-wordiness --checkclean.ds-shotsdiff of03-j-funding-methods-argentina(fixturesetup-payment-plan) on this PR.🤖 Generated with Claude Code