Repository navigation
TASK-24171: retire the waitlist, redirect /shhhhh to /peanut-card - #4113
Draft
kushagrasarathe wants to merge 7 commits into
Draft
kushagrasarathe wants to merge 7 commits into
kushagrasarathe wants to merge 7 commits into
Conversation
/shhhhh, /shhhhh/ and its aliases (/sh, /lp/card) now 308 straight to /peanut-card, so there is one card landing page and no redirect chain. The /peanut-card CTA takes over badge-campaign handling (queue before the store hand-off, claim when signed in), so old campaign links keep their attribution. Native drops /shhhhh from the export; a legacy link opens the web, which redirects. Remove the physical-card list (no physical card exists, so joining it was a false promise), the unsupported-QR 'Get notified' flow (nothing was ever sent), queue-themed loading words and dead door/notify strings. The country drawer stays (demand-signal work keeps it) but stops promising a notification.
Skip Pass, Closed Beta and Card Pioneer copy still promised a skipped waitlist, secret access or future perks. Holders keep the badges; the copy now only says what they did. The API sends its own localized copy, which the API PR changes to match.
prebuild rewrote this generated file during a local build. It is not part of this change.
- Keep only shhhhh.faq: /peanut-card reads it; the rest of the old page's copy was dead weight on every marketing route. - Drop the /card/physical screen-catalogue entry: with no page behind it the route fell into the marketing catch-all and leaked marketing code into captured screens. - One badge-campaign claim at a time across the page's CTAs. - The e2e checks that the campaign rides the store hand-off.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Code-analysis diffPainscore total: 11090.26 → 11070.62 (-19.64) 🆕 New findings (35)
…and 15 more. ✅ Resolved (45)
…and 25 more. 📈 Painscore deltas (top movers)
|
Contributor
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
The pinned content still links /shhhhh. With the page gone, the link check called it broken, although the route now 308s to /peanut-card and the resolver rewrites the link. The mono content branch moves the links.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TASK-24171 retires the waitlist. /shhhhh was a second card landing page, and the app still had a physical-card list (with rank), a QR "Get notified / You're on the list" flow that sent nothing, a country drawer that promised a notification, queue-themed loading words and skip-the-line badge copy.
Change
Routes and attribution
/shhhhh,/shhhhh/*,/sh,/sh/*,/lp/card→ 308 to/peanut-cardin one hop (redirects.json). The query is kept.usePeanutCardCta) now handles badge campaigns (?badge_campaign=,?campaign=,?campaignTag=) like the old page: it queues them before the store hand-off, so the deferred install carries them. A signed-in visitor gets the claim, then/card. A campaign never gates the card.src/app/shhhhhis deleted. Its signup-continuation helper moved tosrc/features/card/card-campaign-acquisition.ts(still settles legacy in-flight markers)./shhhhhresolve to/peanut-card;peanut-cardis a locale-neutral content route.Native
shhhhhleftNATIVE_EXPORT_ROOTS(no page). A legacy/shhhhhlink opens the web in the in-app browser, and the web redirects. Universal links never claimed /shhhhh.Retired mechanisms
/card/physical→/card(307).card.eligibilitydoor strings andsetup.residenceStep.restrictednotify strings removed.shhhhhi18n namespace trimmed tofaq(/peanut-card's FAQ). FAQ q8 no longer invites physical-card interest.API contract (api-contract skill)
GET/POST /rain/cards/{cardId}/physical-waitlist. peanut-api-ts#2155 makes POST answer 410 and GET return nulls.api.openapi.jsonis not regenerated here; the daily sync picks up api#2155 after staging.Tests
src/lib/seo/__tests__/card-redirects.test.ts: each legacy path → /peanut-card permanently, the destination does not redirect, and no static redirect in the table chains or loops (Next's own matcher).usePeanutCardCta.test.tsx: the campaign is queued before the hand-off, guest signup fallback, signed-in claim for every outcome, claim failure still opens /card,badge_campaignparam.card-public.spec.tsopens/shhhhh?campaign=…, expects/peanut-card, and checks thatdest=/cardand the campaign ride the Play referrer.button-press-physics.spec.tsmoved from /shhhhh to /setup and /en/help.next buildpasses; screens node tests match origin/dev (6 failures there too, from a missingjoseworker dependency).next start) curl:/shhhhh,/shhhhh/,/sh,/sh/,/lp/card→ 308/peanut-card(query kept);/card/physical→ 307/card;/peanut-card200.Deploy order
Independent of api#2155. The mono content branch (links → /peanut-card) can publish any time; /peanut-card is already live.
Not verified
Open decisions (for Kush)
/help/waitlist-invite-codeswith a redirect (follow-up).🤖 Generated with Claude Code