Repository navigation
Fix release dispatch for multiline notes - #289
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Tag Release job pushed
v0.4.2and then failed to dispatch Publish. It inserted raw release notes between JSON quotes. The line breaks in PR #288 made that payload invalid.Change
Use the GitHub Actions
toJSONfunction to encode the tag and release notes. Preserve the existing empty string for PRs without a release note. Add recovery instructions for a tag that was pushed before dispatch failed.Verification
Replayed the workflow payload with PR #288's actual note using GitHub's Actions expressions library. The original payload failed JSON parsing. The fixed payload round-tripped the note, quotes, backslashes, tabs, CRLF, Unicode, and literal expression text. Both empty and missing notes produced an empty string. Actionlint passed with the repository's custom Blacksmith runner label allowed.
Release recovery
The existing Publish run built all eight binaries and pushed both Docker images. Apple blocked notarization with
FORBIDDEN.REQUIRED_AGREEMENTS_MISSING_OR_EXPIRED. Once the Account Holder has brought the agreement into effect, rerun the failed jobs on that run to finish publishingv0.4.2. This PR can merge without a release label.