Skip to content

Fix release dispatch for multiline notes - #289

Merged
daveshanley merged 1 commit into
mainfrom
codex/notary-release-preflight
Nov 14, 2026
Merged

daveshanley merged 1 commit into
mainfrom
codex/notary-release-preflight

Conversation

@daveshanley

Copy link
Copy Markdown
Member

Problem

The Tag Release job pushed v0.4.2 and then failed to dispatch Publish. It inserted raw release notes between JSON quotes. The line breaks in PR #288 made that payload invalid.

Change

Use the GitHub Actions toJSON function to encode the tag and release notes. Preserve the existing empty string for PRs without a release note. Add recovery instructions for a tag that was pushed before dispatch failed.

Verification

Replayed the workflow payload with PR #288's actual note using GitHub's Actions expressions library. The original payload failed JSON parsing. The fixed payload round-tripped the note, quotes, backslashes, tabs, CRLF, Unicode, and literal expression text. Both empty and missing notes produced an empty string. Actionlint passed with the repository's custom Blacksmith runner label allowed.

Release recovery

The existing Publish run built all eight binaries and pushed both Docker images. Apple blocked notarization with FORBIDDEN.REQUIRED_AGREEMENTS_MISSING_OR_EXPIRED. Once the Account Holder has brought the agreement into effect, rerun the failed jobs on that run to finish publishing v0.4.2. This PR can merge without a release label.

@daveshanley
daveshanley marked this pull request as ready for review November 13, 2026 21:27
@daveshanley
daveshanley merged commit 44bd369 into main Nov 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant