Repository navigation
Record the external schema file for required changes - #712
Open
daveshanley wants to merge 2 commits into
Open
daveshanley wants to merge 2 commits into
daveshanley wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 315 315
Lines 39758 39760 +2
=========================================
+ Hits 39758 39760 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
daveshanley
marked this pull request as ready for review
November 14, 2026 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema comparisons now record the external file that owns each added or removed
requiredentry. The entry already carried a line and column, but its scalar Go getter had no file index. Doctor could search the root document at those coordinates and fail to render the change.The comparison uses the selected schema's source index and preserves the existing getters. Regression tests cover additions, removals, and an external object selected from an inline
anyOf.Verified with the AsyncAPI fixture from pb33f/openapi-changes#285. The summary renders four changes, including the breaking addition of
currency, and the JSON report identifies the external schema at line 11.