Skip to content

Record the external schema file for required changes - #712

Open
daveshanley wants to merge 2 commits into
mainfrom
codex/required-entry-source
Open

daveshanley wants to merge 2 commits into
mainfrom
codex/required-entry-source

Conversation

@daveshanley

Copy link
Copy Markdown
Member

Schema comparisons now record the external file that owns each added or removed required entry. The entry already carried a line and column, but its scalar Go getter had no file index. Doctor could search the root document at those coordinates and fail to render the change.

The comparison uses the selected schema's source index and preserves the existing getters. Regression tests cover additions, removals, and an external object selected from an inline anyOf.

Verified with the AsyncAPI fixture from pb33f/openapi-changes#285. The summary renders four changes, including the breaking addition of currency, and the JSON report identifies the external schema at line 11.

@codecov

codecov Bot commented Nov 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (88615e4) to head (db27aae).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #712   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          315       315           
  Lines        39758     39760    +2     
=========================================
+ Hits         39758     39760    +2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@daveshanley
daveshanley marked this pull request as ready for review November 14, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant