Repository navigation
Feat/kkiapay widget flow - #9
Merged
Merged
Conversation
The sandbox answers an unknown transaction id with HTTP 400 and
`{ "status": "TRANSACTION_NOT_FOUND" }`, not 404 as assumed. Only this
explicit answer now counts as "not found", whatever the HTTP status.
Found by the opt-in sandbox test, which now passes.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Jules Mahounou <234069818+jules-mahounou@users.noreply.github.com>
Payenv keeps requiring E.164 (a number without its country is ambiguous, and could charge the wrong person), but customers type local numbers. `toE164(phone, country)` converts them, with per-country rules: the leading 0 is a trunk prefix in Nigeria, Ghana, Kenya…, but part of the number in Benin (+22901…) and Côte d'Ivoire. demo: accepts local numbers (via toE164), pre-fills the Kkiapay test number when the FedaPay outage is simulated, and shows widget failures. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Jules Mahounou <234069818+jules-mahounou@users.noreply.github.com>
An apostrophe in "n'a bougé" closed a JavaScript string inside the page template, so the whole inline script failed to load and the form was submitted natively (the page just reloaded). Use a typographic apostrophe. To catch this class of bug: the page moves to page.ts, and a test parses its inline script in every demo configuration (it fails on the original bug). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Jules Mahounou <234069818+jules-mahounou@users.noreply.github.com>
FedaPay (simulated outage) → Kkiapay widget → payenv.confirm succeeded. The status response echoes the widget's partnerId and reports the amount requested (fees apart), which is what confirm's anti-fraud checks rely on. The opt-in sandbox tests pass against the real API. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Jules Mahounou <234069818+jules-mahounou@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Checklist
git commit -s) — see DCOCHANGELOG.md(Unreleased) updated if behavior changed