Skip to content

chore(form): update radius on menu toggle#12542

Open
andrew-ronaldson wants to merge 1 commit into
patternfly:mainfrom
andrew-ronaldson:form-radii
Open

chore(form): update radius on menu toggle#12542
andrew-ronaldson wants to merge 1 commit into
patternfly:mainfrom
andrew-ronaldson:form-radii

Conversation

@andrew-ronaldson

@andrew-ronaldson andrew-ronaldson commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Related to this issue https://redhat.atlassian.net/browse/PF-4351

There is a single menu toggle in one of the examples that shoouldn't be pilled.

A core PR is also in review to fix the same issue in the HTML example.

Summary by CodeRabbit

  • Bug Fixes
    • Improved select control behavior when used inside forms.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9c7ec121-a111-4311-9950-4f7867e22c22

📥 Commits

Reviewing files that changed from the base of the PR and between bd9932f and d41cd17.

📒 Files selected for processing (1)
  • packages/react-core/src/components/Form/examples/FormState.tsx

Walkthrough

The FormState example was updated to add the isInForm prop to the MenuToggle component used within the Select control, with no other behavioral changes.

Changes

Form example update

Layer / File(s) Summary
MenuToggle isInForm prop
packages/react-core/src/components/Form/examples/FormState.tsx
Added the isInForm prop to the MenuToggle rendered for the Select control.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adjusting menu toggle styling in the form example.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants