Skip to content

fix(FilterIcon): Replace FilterIcon with RhUiFilterFillIcon#12524

Merged
kmcfaul merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-filter-icon-with-rh-ui-filter-fill
Jul 8, 2026
Merged

fix(FilterIcon): Replace FilterIcon with RhUiFilterFillIcon#12524
kmcfaul merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-filter-icon-with-rh-ui-filter-fill

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Updated the filter icon styling across toolbar, filter, and table examples/demos to use the new RhUiFilterFillIcon for a consistent look.
  • Documentation
    • Refreshed the related demo and documentation content to match the updated icons shown in the UI examples (including the demo app toolbar views).

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: edbc3b51-74fe-4237-930e-ab46964bccfe

📥 Commits

Reviewing files that changed from the base of the PR and between ddc62a8 and 98ab9d2.

📒 Files selected for processing (28)
  • packages/react-core/src/components/Toolbar/examples/Toolbar.md
  • packages/react-core/src/components/Toolbar/examples/ToolbarComponentManagedToggleGroups.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarConsumerManagedToggleGroups.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarCustomLabelGroupContent.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarStacked.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarWithFilters.tsx
  • packages/react-core/src/demos/Filters/FilterDemos.md
  • packages/react-core/src/demos/Filters/examples/FilterAttributeSearch.tsx
  • packages/react-core/src/demos/Filters/examples/FilterCheckboxSelect.tsx
  • packages/react-core/src/demos/Filters/examples/FilterFaceted.tsx
  • packages/react-core/src/demos/Filters/examples/FilterMixedSelectGroup.tsx
  • packages/react-core/src/demos/Filters/examples/FilterSameSelectGroup.tsx
  • packages/react-core/src/demos/Filters/examples/FilterSingleSelect.tsx
  • packages/react-core/src/demos/PrimaryDetail.md
  • packages/react-core/src/demos/Tabs.md
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsx
  • packages/react-core/src/demos/examples/Tabs/TabsAndTable.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarVisibilityDemo.tsx
  • packages/react-table/src/demos/Table.md
  • packages/react-table/src/demos/examples/TableColumnManagement.tsx
  • packages/react-table/src/demos/examples/TableColumnManagementWithDraggable.tsx
  • packages/react-table/src/demos/examples/TableCompact.tsx
  • packages/react-table/src/demos/examples/TableCompoundExpansion.tsx
  • packages/react-table/src/demos/examples/TableFilterable.tsx
  • packages/react-table/src/demos/examples/TableStaticBottomPagination.tsx
✅ Files skipped from review due to trivial changes (18)
  • packages/react-table/src/demos/examples/TableFilterable.tsx
  • packages/react-core/src/demos/Filters/FilterDemos.md
  • packages/react-core/src/components/Toolbar/examples/ToolbarStacked.tsx
  • packages/react-table/src/demos/examples/TableColumnManagementWithDraggable.tsx
  • packages/react-core/src/demos/Filters/examples/FilterSameSelectGroup.tsx
  • packages/react-core/src/demos/Filters/examples/FilterMixedSelectGroup.tsx
  • packages/react-table/src/demos/examples/TableStaticBottomPagination.tsx
  • packages/react-core/src/components/Toolbar/examples/Toolbar.md
  • packages/react-table/src/demos/Table.md
  • packages/react-core/src/demos/Tabs.md
  • packages/react-core/src/demos/Filters/examples/FilterCheckboxSelect.tsx
  • packages/react-core/src/demos/PrimaryDetail.md
  • packages/react-core/src/components/Toolbar/examples/ToolbarCustomLabelGroupContent.tsx
  • packages/react-core/src/demos/Filters/examples/FilterAttributeSearch.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarVisibilityDemo.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarWithFilters.tsx
  • packages/react-core/src/demos/examples/Tabs/TabsAndTable.tsx
🚧 Files skipped from review as they are similar to previous changes (10)
  • packages/react-core/src/components/Toolbar/examples/ToolbarConsumerManagedToggleGroups.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx
  • packages/react-table/src/demos/examples/TableCompoundExpansion.tsx
  • packages/react-table/src/demos/examples/TableCompact.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarComponentManagedToggleGroups.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsx
  • packages/react-table/src/demos/examples/TableColumnManagement.tsx
  • packages/react-core/src/demos/Filters/examples/FilterFaceted.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsx
  • packages/react-core/src/demos/Filters/examples/FilterSingleSelect.tsx

Walkthrough

All FilterIcon usages in the affected Toolbar, Filter, PrimaryDetail, Tabs, integration toolbar, and Table demo files were replaced with RhUiFilterFillIcon. Imports and icon props were updated; component structure and behavior were unchanged.

Changes

FilterIcon → RhUiFilterFillIcon icon replacement

Layer / File(s) Summary
Toolbar example icon swap
packages/react-core/src/components/Toolbar/examples/Toolbar.md, packages/react-core/src/components/Toolbar/examples/Toolbar*.tsx
Markdown and Toolbar example components replace FilterIcon imports and toggleIcon usages with RhUiFilterFillIcon.
Filter demo icon swap
packages/react-core/src/demos/Filters/FilterDemos.md, packages/react-core/src/demos/Filters/examples/Filter*.tsx
Filter demo markdown and example components replace FilterIcon with RhUiFilterFillIcon in MenuToggle and ToolbarToggleGroup icon props.
PrimaryDetail and Tabs demo icon swap
packages/react-core/src/demos/PrimaryDetail.md, packages/react-core/src/demos/Tabs.md, packages/react-core/src/demos/examples/PrimaryDetail/..., packages/react-core/src/demos/examples/Tabs/TabsAndTable.tsx
PrimaryDetail and Tabs demo markdown/files replace FilterIcon imports and toggleIcon usage with RhUiFilterFillIcon.
Integration test toolbar demo icon swap
packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarDemo.tsx, packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarVisibilityDemo.tsx
Integration toolbar demo components update the icon import and ToolbarToggleGroup toggleIcon usages to RhUiFilterFillIcon.
Table demo icon swap
packages/react-table/src/demos/Table.md, packages/react-table/src/demos/examples/Table*.tsx
Table demo markdown and example components replace FilterIcon imports and MenuToggle or ToolbarToggleGroup icon usages with RhUiFilterFillIcon.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: thatblindgeye, kmcfaul, nicolethoen

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: replacing FilterIcon with RhUiFilterFillIcon across the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 24, 2026 01:39
@rebeccaalpert rebeccaalpert requested a review from kmcfaul June 24, 2026 13:16
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-filter-icon-with-rh-ui-filter-fill branch from d1d8d4c to ddc62a8 Compare July 8, 2026 14:56
Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-filter-icon-with-rh-ui-filter-fill branch from ddc62a8 to 98ab9d2 Compare July 8, 2026 17:44
@kmcfaul kmcfaul merged commit f8bcd7c into patternfly:main Jul 8, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants