Skip to content

fix(PlusIcon): Replace PlusIcon with RhUiAddIcon#12520

Merged
kmcfaul merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-plus-icon-with-rh-ui-add
Jul 8, 2026
Merged

fix(PlusIcon): Replace PlusIcon with RhUiAddIcon#12520
kmcfaul merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-plus-icon-with-rh-ui-add

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style

    • Updated “Add/Plus” icons across Card, MenuToggle, NumberInput, Slider, Tabs, and Tile to use the Red Hat UI icon set, keeping the same visual placement on all related action buttons.
  • Documentation

    • Refreshed component example documentation to reference the new icon for “custom icon” and “add” scenarios.
  • Tests

    • Updated Tile snapshot tests to reflect the new icon rendering.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@rebeccaalpert, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 seconds

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1a6901d7-ebd4-4347-ab07-152c232ca26a

📥 Commits

Reviewing files that changed from the base of the PR and between ab5acfd and e1c1446.

⛔ Files ignored due to path filters (2)
  • packages/react-core/src/components/NumberInput/__tests__/__snapshots__/NumberInput.test.tsx.snap is excluded by !**/*.snap
  • packages/react-core/src/deprecated/components/Tile/__tests__/__snapshots__/Tile.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (12)
  • packages/react-core/src/components/Card/examples/Card.md
  • packages/react-core/src/components/Card/examples/CardTile.tsx
  • packages/react-core/src/components/Card/examples/CardTileMulti.tsx
  • packages/react-core/src/components/MenuToggle/examples/MenuToggle.md
  • packages/react-core/src/components/MenuToggle/examples/MenuToggleCustomIcon.tsx
  • packages/react-core/src/components/NumberInput/NumberInput.tsx
  • packages/react-core/src/components/Slider/examples/Slider.md
  • packages/react-core/src/components/Slider/examples/SliderActions.tsx
  • packages/react-core/src/components/Tabs/Tabs.tsx
  • packages/react-core/src/deprecated/components/Tile/__tests__/Tile.test.tsx
  • packages/react-core/src/deprecated/components/Tile/examples/Tile.md
  • packages/react-core/src/deprecated/components/Tile/examples/TileWithIcon.tsx

Walkthrough

PlusIcon is replaced with RhUiAddIcon in component implementations, examples, markdown docs, and deprecated Tile snapshot tests.

Changes

PlusIcon → RhUiAddIcon replacement

Layer / File(s) Summary
Component implementation icon swap
packages/react-core/src/components/NumberInput/NumberInput.tsx, packages/react-core/src/components/Tabs/Tabs.tsx
NumberInput and Tabs update their icon imports and render RhUiAddIcon for the plus/add button.
Examples and docs icon swap
packages/react-core/src/components/Card/examples/Card.md, packages/react-core/src/components/Card/examples/CardTile.tsx, packages/react-core/src/components/Card/examples/CardTileMulti.tsx, packages/react-core/src/components/MenuToggle/examples/MenuToggle.md, packages/react-core/src/components/MenuToggle/examples/MenuToggleCustomIcon.tsx, packages/react-core/src/components/Slider/examples/Slider.md, packages/react-core/src/components/Slider/examples/SliderActions.tsx, packages/react-core/src/deprecated/components/Tile/examples/Tile.md, packages/react-core/src/deprecated/components/Tile/examples/TileWithIcon.tsx
Example code and docs switch imports, rendered icons, and custom icon text from PlusIcon to RhUiAddIcon.
Tile snapshot test icon swap
packages/react-core/src/deprecated/components/Tile/__tests__/Tile.test.tsx
Tile snapshot tests use RhUiAddIcon in the regular, stacked, and stacked-large cases.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: kmcfaul, thatblindgeye, nicolethoen

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: replacing PlusIcon with RhUiAddIcon.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-plus-icon-with-rh-ui-add branch from 1a08782 to ec81521 Compare June 23, 2026 22:23
@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 23, 2026 22:23
@rebeccaalpert rebeccaalpert requested a review from kmcfaul June 24, 2026 13:17
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-plus-icon-with-rh-ui-add branch from ec81521 to ab5acfd Compare July 8, 2026 14:18
Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-plus-icon-with-rh-ui-add branch from ab5acfd to e1c1446 Compare July 8, 2026 15:17
@kmcfaul kmcfaul merged commit b933d5a into patternfly:main Jul 8, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants