Skip to content

fix(QuestionIcon): Replace QuestionIcon with RhUiQuestionMarkIcon#12509

Merged
kmcfaul merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-question-icon-with-rh-ui-question-mark
Jul 8, 2026
Merged

fix(QuestionIcon): Replace QuestionIcon with RhUiQuestionMarkIcon#12509
kmcfaul merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-question-icon-with-rh-ui-question-mark

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Documentation
    • Updated HelperText component examples to showcase an alternative icon option (switching to a question mark icon).

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ba850afa-3a6c-42b6-912b-89062b898498

📥 Commits

Reviewing files that changed from the base of the PR and between 70b11bb and 3871553.

📒 Files selected for processing (2)
  • packages/react-core/src/components/HelperText/examples/HelperText.md
  • packages/react-core/src/components/HelperText/examples/HelperTextWithCustomIcon.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/react-core/src/components/HelperText/examples/HelperTextWithCustomIcon.tsx

Walkthrough

HelperText example code and documentation now use RhUiQuestionMarkIcon instead of QuestionIcon for the indeterminate helper text icon.

Changes

HelperText icon replacement

Layer / File(s) Summary
Icon import and usage update in HelperText example
packages/react-core/src/components/HelperText/examples/HelperTextWithCustomIcon.tsx, packages/react-core/src/components/HelperText/examples/HelperText.md
Replaces QuestionIcon with RhUiQuestionMarkIcon in the example import, the HelperTextItem icon prop, and the matching markdown snippet.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: thatblindgeye, kmcfaul

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: replacing QuestionIcon with RhUiQuestionMarkIcon.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@thatblindgeye thatblindgeye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise looks good, however this particular RH icon to me is rather difficult to see due to how thin it is.

@rebeccaalpert rebeccaalpert requested a review from kmcfaul June 24, 2026 13:20
Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-question-icon-with-rh-ui-question-mark branch from 70b11bb to 3871553 Compare July 8, 2026 15:01
@kmcfaul kmcfaul merged commit 075bb72 into patternfly:main Jul 8, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants