Skip to content

fix(AngleUpIcon): Replace AngleUpIcon with RhMicronsCaretUpIcon#12497

Merged
kmcfaul merged 2 commits into
patternfly:mainfrom
rebeccaalpert:cursor/replace-angle-up-icon-with-rh-microns-caret-up
Jul 8, 2026
Merged

fix(AngleUpIcon): Replace AngleUpIcon with RhMicronsCaretUpIcon#12497
kmcfaul merged 2 commits into
patternfly:mainfrom
rebeccaalpert:cursor/replace-angle-up-icon-with-rh-microns-caret-up

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 18, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Bug Fixes
    • Updated the previous-navigation caret icon in the search input to use a different icon for a more consistent appearance.
    • Updated the next-navigation and submit/search arrow icons in the search input.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: adc65acf-242a-42f0-a867-933c3787e486

📥 Commits

Reviewing files that changed from the base of the PR and between fbedebc and 9b83a06.

⛔ Files ignored due to path filters (1)
  • packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (1)
  • packages/react-core/src/components/SearchInput/SearchInput.tsx
✅ Files skipped from review due to trivial changes (1)
  • packages/react-core/src/components/SearchInput/SearchInput.tsx

Walkthrough

SearchInput.tsx now uses updated RhMicrons icons for the previous and next navigation controls and for the submit button. No component API, props, or search behavior changes.

Changes

SearchInput Icon Update

Layer / File(s) Summary
Update SearchInput icons
packages/react-core/src/components/SearchInput/SearchInput.tsx
Replaces the imported icon set and updates the previous, next, and submit button icon usages to RhMicronsCaretUpIcon, RhMicronsCaretDownIcon, and RhMicronsArrowRightIcon.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: kmcfaul, thatblindgeye, nicolethoen

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately describes the primary icon replacement in SearchInput.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-angle-up-icon-with-rh-microns-caret-up branch from b747214 to 40d217f Compare June 18, 2026 19:49
@patternfly-build

patternfly-build commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert requested a review from kmcfaul June 24, 2026 13:19
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-angle-up-icon-with-rh-microns-caret-up branch from 40d217f to fbedebc Compare June 30, 2026 18:56
isDisabled={isDisabled || isPreviousNavigationButtonDisabled}
onClick={onPreviousClick}
icon={<AngleUpIcon />}
icon={<RhMicronsCaretUpIcon />}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "next" button below is using the RhMicronsCaretDownFillIcon (Fill, not base). Do we want to update this icon to match?

@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-angle-up-icon-with-rh-microns-caret-up branch from fbedebc to 9b83a06 Compare July 8, 2026 17:14
@kmcfaul kmcfaul merged commit a7d4365 into patternfly:main Jul 8, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants