fix(MessageBar): Replace send button icon - #903
Open
gabipodolnikova wants to merge 1 commit into
Open
Conversation
|
Preview: https://chatbot-pr-chatbot-903.surge.sh A11y report: https://chatbot-pr-chatbot-903-a11y.surge.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the PaperPlaneIcon used by SendButton with the RH Ui Send icon from
@patternfly/react-icons.This currently uses the prerelease dependency
@patternfly/react-icons@6.6.1-prerelease.2, released after PF-4576. The dependency can be updated to the stable release without code changes once available.Restore PatternFly's default plain icon-button interaction styles while preserving the brand color for the default state.
Fixes #880
Tests:
npx jest --runInBand packages/module/src/MessageBar/SendButton.test.tsxnpm run build -w @patternfly/chatbotnpx eslint packages/module/src/MessageBar/SendButton.tsx