Repository navigation
suite: write dropped build reasons into dropped/REASONS.md - #171
Merged
Merged
Conversation
--drop-failed moved a failed task out of the suite but left the reason on stderr, where the next run cannot see it. Keep each task's build error while building and write dropped/REASONS.md with the slug and log tail. Covered by a CLI test with a fake failing build, so no Docker.
Owner
|
yes rewriting is fine i dont want to display everything in the history. I will approve the pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Closes #85.
suite build-images --drop-failedmoves a task whose image failed to build intodropped/, but the error only went to stderr. The command now keeps each failed task's error string while building and writesdropped/REASONS.mdwith a section per slug and the build-log tail, before moving the task files. The terminal output is unchanged.How it was checked
make checkpasses (ruff,mypy --strict, unit tests) — excepttests/unit/test_web_vectors.py, which fails identically on a cleanmainhere (t_quantilediffers in the last bit); unrelated.test_a_dropped_task_leaves_its_reason_in_the_suiterunssuite build-images --drop-failedwithbuild_snapshotpatched to raise, then asserts the task file moved todropped/,REASONS.mdnames the slug, and the error tail is present. No Docker needed.make integration/make e2e— not needed; the image build itself is unchanged and the new path is pure file I/O after a build failure.Anything a reviewer should know
REASONS.mdis rewritten by each--drop-failedrun. A later run only lists tasks that run dropped, not the whole history; if you want an append-only log or JSON instead, say so and I will switch the format.textblocks; a build log that itself contains a four-backtick run could break rendering. I can indent instead if that matters.