Repository navigation
suites: suggest import-harbor when a directory looks like Harbor tasks - #170
Merged
Merged
Conversation
Pointing run or publish at a Harbor dataset used to fail with only "no suite.yaml", which says nothing about the command that converts it. The missing-suite-file issue now carries the hint when task.toml appears at the dataset root, one level down, or two. A plain directory stays hint-free.
Owner
|
nice jobs but make sure to get this task assigned to you next time and tell your approach before working on it. please read CONTRIBUTIONS.md. I will merge this one |
patsypppe
added a commit
that referenced
this pull request
Nov 8, 2026
…172) A pull request from a fork gets a read-only token, so the Comment step failed with 'Resource not accessible by integration' and turned a passing gate red (seen on #170, where the verdict was pass). Skip the comment for forks and always write the verdict to the job summary instead. Claude-Session: https://claude.ai/code/session_017urKavHf7CSyMqnzeCCyoy Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Closes #83.
load_suitealready reportsmissing_suite_filewhen a directory has nosuite.yaml. That issue's message now adds "this looks like Harbor tasks — runmeridian import-harborfirst" whentask.tomlis present at the dataset root, one directory down, or two — the layoutsfind_task_dirsaccepts. The CLI prints every validation issue's message, sorun,publish,gateandsuite build-imagesall get the hint. A directory without atask.tomlkeeps the plain message.How it was checked
make checkpasses (ruff,mypy --strict, unit tests) — excepttests/unit/test_web_vectors.py, which fails identically on a cleanmainhere (t_quantilediffers in the last bit); unrelated to this change. The rest of the unit suite is 574 passed.import-harborin the message, a plain directory does not, and both still reportmissing_suite_file.make integration/make e2e— not needed for the loader; this change adds no runtime path.Anything a reviewer should know
missing_suite_filekeep working.importers/harbor.pyrather than importing the importer into the loader; happy to share a helper if you would rather have one source of truth.