Repository navigation
chore(deps): Gradle 9.9.1, AGP 9.5.1, plugins; fix two 2.7.56 crashes - #182
Merged
Merged
Conversation
- Gradle wrapper 9.2.1 -> 9.9.1 - AGP 9.0.1 -> 9.5.1 - Hilt 2.57.2 -> 2.60.1 - Spotless 8.10.1 -> 8.11.0 - google-services 4.4.4 -> 4.6.0 - Minor library bumps: Room 2.8.5, appcompat 1.8.0, work-runtime 2.12.0, credentials 1.6.0, googleid 1.2.1, gson 2.15.0, mockito 5.24.0, truth 1.4.5, robolectric 4.17
Test coverage (unit + instrumentation)
Files
|
In selecting mode (Shift held on a hardware keyboard) ArrowKeyMovementMethod extends the selection from the offset it recorded on the down. When the down came before selecting started nothing was recorded, it selected from -1 and crashed with "setSpan (-1 ... -1) starts before 0" (Play Console, 2.7.56). The selection now stays as it was.
On Android 10 with Do Not Disturb on, AudioManager.setStreamVolume throws "Not allowed to change Do Not Disturb state" without notification policy access (Play Console, 2.7.56). The refusal is caught and the slider goes back to the volume actually in effect.
pasichDev
changed the title
Clears the advisories that fail the CI audit step (--audit-level=high): source-map-js (high), colord, postcss-selector-parser and serialize-javascript. Only build tooling changes; the generated editor bundles are byte-identical. Two low-severity deepmerge advisories remain: their fix would downgrade @rollup/plugin-node-resolve to 7.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Build tooling upgrade plus minor/patch library bumps, and fixes for two Play Console crashes in 2.7.56.
The wrapper scripts and jar were regenerated with
./gradlew wrapper --gradle-version 9.9.1.Crash fixes (Play Console, 2.7.56)
IndexOutOfBoundsException: setSpan (-1 ... -1) starts before 0inEditableLinkMovementMethod.onTouchEvent(note editor). In selecting mode (Shift on a hardware keyboard)ArrowKeyMovementMethodextends the selection from the offset it recorded on the down; when the down came before selecting started, it selects from -1. Reproduced in a Robolectric test (EditableLinkMovementMethodTest, SDK 28 and 35), which fails without the fix.SecurityException: Not allowed to change Do Not Disturb stateinMediaSettingsFragment(volume slider, Android 10 with DND on). The refusal is caught and the slider snaps back to the real volume.Not fixable from the app (no app frames in the trace):
ArrayIndexOutOfBoundsExceptioninDynamicLayout.getBlockIndexduringEditor.onDraw: a known Android 8.x platform bug.SIGSEGVinlibart.soThreadList::RunEmptyCheckpointduring GC: an ART runtime crash on one Android 9 device.Not included (separate PR)
Major bumps that need code changes or a reformat:
BillingManager,SupportActivity)Verification
./gradlew spotlessCheck test lint assembleReleasepasses locally (JDK 17), including the new test.