Repository navigation
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3e77190. Configure here.
2 of 4 tasks
kvnloo
added a commit
to kvnloo/editor
that referenced
this pull request
Nov 7, 2026
Cover registry-aware create, render install gate, durable scene JSON, and the get_scene MCP wire listing under explicit uninstallation and missing-plugin reload. Keep upstream pascalorg#1225 intact. PE39-1225-SCENE-INSTALL-SEMANTICS
kvnloo
added a commit
to kvnloo/editor
that referenced
this pull request
Nov 7, 2026
…ssion branch Restore the six unrelated viewer files to fork main and remove the two GLB batching files added by ancestor 0602f9e. Preserve all MCP bridge production changes and exported-package regression tests unchanged. PE44-1225-ANCESTRY-DIFF-HYGIENE
Retain registered-plugin parsing and schema-specific error paths while incorporating upstream hierarchy-cycle parity checks. Resolve the sole test import conflict by preserving both imports. Integrated source passed uncached MCP build and1532 tests,12 plugin conformance tests, formatting and exact-source independent review. No upstream merge or release is performed by this source commit.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
SceneBridgecurrently parses create patches andvalidateScene()against the built-in node union only. A node kind registered through the plugin registry can therefore work in core/plugin flows but still be rejected at the MCP bridge boundary.This change keeps the built-in parser as the first path, then falls back to the registered schema for the node's
typewhen the built-in parse fails. The same helper is used for create patches and scene validation.A focused regression test registers a minimal plugin kind, creates it through
applyPatch, and verifies that the resulting scene validates cleanly.Built-in and unregistered node behavior is unchanged.
How to test
Validated against current
main:bun x biome check packages/mcp/src/bridge/scene-bridge.ts packages/mcp/src/bridge/scene-bridge.test.tsbun test packages/mcp/src/bridge/scene-bridge.test.ts→ 56 passed, 0 failedbunx turbo run test --filter=@pascal-app/mcp→ 1,516 passed, 0 failedbun test packages/core/src/registry/plugin-v1-conformance.test.ts→ 12 passed, 0 failedbun --cwd packages/mcp run build→ passedbun run check→ exit 0Screenshots
Not applicable. This is a headless MCP bridge change.
Checklist
bun dev(not applicable to this headless bridge change)bun check)mainbranchNote
Low Risk
Localized parsing/validation change in the headless MCP bridge with regression tests; built-in node behavior is unchanged.
Overview
The MCP SceneBridge no longer validates nodes only against the built-in
AnyNodeunion. It now uses a sharedparseRegisteredNodehelper that keepsparseNodeas the first path and, on failure, validates against the pluginnodeRegistryschema for the node'stype.That helper is wired into
applyPatchcreate validation andvalidateScene, so plugin kinds can be created through patches and pass scene checks when they match their registered schema; invalid plugin payloads still fail with schema errors.A regression test registers a minimal plugin kind, creates it via
applyPatch, and asserts valid/invalidvaluehandling in both patch apply andvalidateScene.Reviewed by Cursor Bugbot for commit 96e3f3d. Bugbot is set up for automated code reviews on this repo. Configure here.