Repository navigation
📚 docs: verification: route rules to their enforcers - #401
Merged
Merged
Conversation
Record D067 and link template rules to their existing checks. Require Acceptance in the rendered reading order and correct skill guidance. Keep verification evidence after cleanup of read-only Go module folders.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COR-103 rules repeat machine checks in prose, and the template reading order omits
## Acceptance.D067 assigns each check to its owner. The template links rules to existing enforcers and keeps human judgment in prose. QA links error scenarios. The skills explain JSON failures and formal verification. The verification harness handles read-only Go caches and documents the no-model refusal. T1 and T13 are marked done.
Proved by:
uv run --no-project --python 3.12 just check; the reading-order check exits 1 at32b52e71and passes on this head; cleanup exits 1 before the fix and 0 after it, with evidence preservedjust checkpassestemplateandagentat9551c675, clean (evidence/commit.txt:9551c675d3c1):ncly v0.23.4-0.20261030060552-9551c675d3c1; every step oftemplateandagentpassesncly describe nothere --json: exit 2, and stderr ends with{"ok":false,"contract_version":1,"errors":[{"code":"NOT_FOUND",...}]}AGENTS.mdreading order:2. \spec.md`, including `## Acceptance`: each command's success criteria, effects, and failures`Each running command executes in a scenario,Call only through ncly, ncly-probe, exits, signal, or refuses, andEach manifest example runsjust verify cleanupwith the changedcleanup.sh: exit 0, scratch and build removed, evidence keptnicelyfor core (no README change needed)just signoffpasses, orjust signoff-layersfor a stack (pending: root)The required size splits have separate commits. Skill maintenance used live scratch runs. The remote transcript path stopped at
TERMINAL_REQUIRED. Five existing feature cross-link warnings remain in the skill validator.Root review: Opus 5.5 read the full diff. Core's
## Rulesmoved unchanged toRULES.mdto keepAGENTS.mdunder its size limit; Sol checked that agents still find them.Reviewed with sol-loop: 1 round with gpt-6.1-sol on xhigh. Sol verdict: approved
by GPT-6.1-Sol via Codex