Repository navigation
✨ feat: extensiontest: run manifest examples safely - #394
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
pascalandy
force-pushed
the
cor-103-t4-run-examples
branch
from
October 30, 2026 03:13
7f154ee to
c233fbe
Compare
- Purpose: catch examples that cannot prepare, including COR-103-T4 defect D069 - Impact: check example answers in scratch folders and require explicit safety before execution
- Purpose: expose skipped examples after Go filters passing test output - Impact: share the notice path with declared-code checks
- Purpose: Preserve cached core tests and valid JSON test output - Impact: Print collected notices on stderr in rendered extension checks
pascalandy
force-pushed
the
cor-103-t4-run-examples
branch
from
October 30, 2026 03:35
6955b06 to
f1041ca
Compare
- Purpose: Run T4's manifest example inside T6's paired and signal fixtures - Impact: The paired fixture answers its declared dry run without a key, and only hang.mov starts the endless child Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Purpose: Keep the notice test working now that the template command offers a dry run - Impact: An example of ncly describe gives the skip notice that plain and JSON checks must show Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Purpose: Keep test-kit.md under its size limit after T4 and T6 - Impact: The Manifest examples section moves unchanged to manifest-examples.md, linked from test-kit.md and the contract index Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manifest examples could pass
just checkeven when command preparation refused them.The agent examples omitted their required model value, which parsing alone could not detect.
Run each example in fresh scratch folders with scenario fixtures and the shared answer check.
Use a dry run when available, and require declared unpaid effects for other runs.
Print each skip reason, and keep example calls separate from scenario coverage.
The agent examples now include
--model MODEL_ID.Proved by: D069 returned exit 2 before the example fix and exit 0 afterward;
uv run --no-project --python 3.12 just checkpasses.just checkpassesagentat7f154ee1, clean (evidence/commit.txt:7f154ee10c3c). The later fixes change only how notices print, not the examples or the agent feature:ncly v0.23.4-0.20261030024727-7f154ee10c3c; Install, Discovery, Help, Dry run, Dry run as text, No record, and Without --tools ofagentpassncly agent run --helplists$ ncly agent run "Review this branch" --tools --model MODEL_ID --effort high --dry-runand$ ncly agent run --task-file task.md --tools --model MODEL_ID --run-id review-1 --jsontest-model: exit 0,"dry_run":true,"model":"test-model","effort":"high"--model: exit 2,"code":"USAGE_INVALID","message":"No model is set for Codex."nicelyfor core. No new product commandjust signoffpasses, orjust signoff-layersfor a stackReview fixes: a skipped example's reason is a notice that the template's
just checkprints after the test results, throughgo run ./internal/export test(Sol S1). Core keeps its cachedgo testlines (S2), and the notices go to stderr, so-jsonoutput stays valid (S3). Card T5 reusesextensionrepo.Noticefor itsuntestedreasons.Rebase onto T6 (nicely#396): T6's fixture tests now run T4's manifest examples. The paired fixture answers its declared dry run without a key, since ncly passes no key in a dry run, and only
hang.movstarts the cleanup test's endless child (03f7dc08). The template's command now offers a dry run, so the notice test uses an example ofncly describe, which the kit skips (d38bc5ae). The Manifest examples section moves unchanged tomanifest-examples.mdto keeptest-kit.mdunder its size limit (9a7c2317). Separate Sol reviews approved03f7dc08andd38bc5ae. The split moves text without a change.Root review: Opus 5.5 read the full diff and each fix, and wrote the three rebase commits.
Reviewed with sol-loop: 3 rounds with gpt-6.1-sol on xhigh. Sol verdict: approved
by GPT-6.1-Sol via Codex