test: guard CLI errors against stack trace leaks - #133
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Parvez Kose <koseparvez@gmail.com>
Co-authored-by: Parvez Kose <koseparvez@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
Test files
test/cli.test.ts, a black-box subprocess test of the real CLI entrypoint.Regression value
This directly protects the recent CLI information-disclosure fix. Replacing the guarded
parseAsync()rejection handler with the previous bare call makes the test fail on the emitted source location and stack trace, proving the test detects the security regression without changing production behavior.Validation
npm exec vitest -- run— 133 tests passednpm run build— passednpm exec prettier -- --check test/cli.test.ts— passed