Polish Prompt Cards with Rounded Corners & Copy Feedback - #117
Conversation
aashu2006
left a comment
There was a problem hiding this comment.
thanks for this @klprakhar ! The copy feedback idea is good, but a couple of things need sorting first
Contrast: bg-green-500 with text-white is 2.28:1. WCAG AA needs 4.5:1 for text this size, so this is a regression against the bg-gold text-gold-foreground it replaces, which passes comfortably. green-700 would get you to 5.02:1 if we stay with green.
Design tokens: there are currently zero raw palette colors in src/. Everything goes through the semantic tokens in index.css, which have separate light and dark values. bg-green-500 is a fixed hex, so it will look right in light mode and wrong in dark. If we want a success color, please add --success and --success-foreground to index.css with both theme values and use bg-success
Rounded corners: rounded-sm is used 44 times and is the card language here. rounded-xl appears 6 times, all on static content pages, never on a gallery card. Rounding only the card container and the detail image puts a rounded-xl frame directly around rounded-sm badges and buttons, which reads as less consistent rather than more. Either we do this as a systematic radius change across the card surfaces, or we leave it.
Small one: the : "" branch is unnecessary, cn() drops falsy values already.
What does this change?
Improves the visual consistency and feedback of prompt cards and the prompt detail page.
Why?
How was it tested?
Checklist
npm run lintpassesnpm run typecheckpassesnpm testpassesnpm run buildpasses/foo.png) is inpublic/, notsrc/assets/.envfiles are included