Photos: part 4#235
Open
franciscoaguirre wants to merge 42 commits into
Open
Conversation
Merged
danielbui12
reviewed
Jun 25, 2026
Address PR #229 review feedback (danielbui12): - Extract the duplicated M2/M3 "re-enumerate -> recompute root -> read on-chain anchor (retry for best-block lag) -> assert recomputed == on-chain == index_root" block into a local verifyAnchor helper, parameterized by an isStale predicate. - Replace the hardcoded retry bound 5 with a named ANCHOR_RETRY_BLOCKS constant. Behavior-preserving: identical asserts and console output.
franciscoaguirre
force-pushed
the
photos-3
branch
from
8d63cae to
8a309f6
Compare
bkontur
reviewed
Jun 26, 2026
bkontur
approved these changes
Jun 26, 2026
franciscoaguirre
force-pushed
the
photos-4
branch
from
7ff2052 to
88e45bf
Compare
* feat(photos): cropping and rotating * feat(photos): no longer wait on reanchoring * feat: delete
Address PR #229 review feedback (danielbui12): - Extract the duplicated M2/M3 "re-enumerate -> recompute root -> read on-chain anchor (retry for best-block lag) -> assert recomputed == on-chain == index_root" block into a local verifyAnchor helper, parameterized by an isStale predicate. - Replace the hardcoded retry bound 5 with a named ANCHOR_RETRY_BLOCKS constant. Behavior-preserving: identical asserts and console output.
franciscoaguirre
force-pushed
the
photos-3
branch
from
8a309f6 to
f0235de
Compare
Bring photos-3's dev sync (CI, dependabot, deps), the new shared chain-client package, and SDK additions (core/merkle.ts, layer1 fs client) into photos-4. Photos UI conflicts resolved in favor of photos-4's part-5 work (reworked contract/ABI, self-contained chain-client). Dropped photos-3's stale scripts/ build pipeline (superseded by contracts/) and the orphaned layer1 merkle WIP in favor of core/merkle.ts. Lockfile regenerated.
franciscoaguirre
force-pushed
the
photos-4
branch
from
3315d1f to
7117876
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #133