test(server): fix the host_core boot-reconcile race in the product-subtree tests - #589
Merged
Merged
Conversation
Both product-subtree tests set a session directly on a runtime whose session store is empty, so the boot reconcile's clear could land on top of it and the call answered Disconnected. They now wait for the opening auth state before installing, which reports after the clear. The wait helper moves to test_support so both test modules share it.
pgherveou
approved these changes
Sep 3, 2026
TarikGul
approved these changes
Sep 3, 2026
pgherveou
reviewed
Sep 3, 2026
pgherveou
approved these changes
Sep 3, 2026
pgherveou
enabled auto-merge
September 3, 2026 13:16
pgherveou
disabled auto-merge
September 3, 2026 13:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
host_coreproduct-subtree tests install a session directly on aPairingHostRuntimewhose session store is empty. The boot reconcile runs on its own thread and clears the in-memory session when it finds nothing, so its clear can land after the test installed the session and the call under test answersDisconnectedinstead.a_cached_subtree_answers_without_reaching_the_walletfailed this way in the merge queue; locally the pair fails about 2 runs in 15.Both tests now wait for the opening auth state before installing the session. The core reports that state after the boot reconcile has finished clearing, so the install always lands last. The two-second wait helper moves from the runtime tests into
test_supportso both modules share one copy.