Repository navigation
Add a funnel sample to the demo, and let a series set its label colour #75
Description
Add a funnel chart sample to the demo at https://chartmagic.panoramicdata.com/. The renderer has drawn funnels since #72.
Adding it exposed a gap: SeriesSpecification had no label colour. The renderer reads Series.FontColor, but the specification never set it, so every series label was black, including data labels, outside pie labels and funnel labels. On the demo's dark theme they could not be read.
Acceptance criteria
- MUST The demo gallery has a Working "Funnel" sample that renders one labelled segment per stage.
- MUST
SeriesSpecification.FontColorsets the colour of that series' labels. It defaults to black, so existing output does not change. - MUST The demo themes series labels (
theme.AxisLabel) unless the sample sets its own colour.
Activity
davidnmbond commentedon Sep 28, 2026
Done in 082b8c8 and live on https://chartmagic.panoramicdata.com/ (9.1.42).
DemoSampleTests.Funnel_IsInTheGallery_AsWorkingandFunnel_RendersOneLabelledSegmentPerStage_InBothThemes. On the live site, the Funnel tab renders 5 segments per theme, labelled "Visitors: 1000" through "Customers: 260".SeriesSpecification.FontColorsets the label colour, default blackDataLabelAndFunnelTests.Funnel_LabelsAreDrawnInTheSeriesFontColorandColumnChart_DataLabelsAreDrawnInTheSeriesFontColor. Red-checked: with the mapping line removed, all five new colour tests fail.DemoSampleTests.SeriesLabels_TakeTheThemeLabelColour_SoTheyAreReadableOnADarkPage(light and dark) andSeriesLabels_ASampleThatSetsItsOwnLabelColour_KeepsIt.Full suite: 113 passed, 0 failed.
The sample data is deliberately shallow. Funnel labels are not moved apart when they collide, so realistic steep data (12000 down to 380) overlaps its last two labels. That is a renderer limitation, not something this change addresses.