Repository navigation
feat: PDDiffPanel, a Monaco diff view - #248
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…off, MonacoLanguage Rename DiffLanguage to MonacoLanguage and make EffectiveLanguage/HasChanges internal. Remove BlazorMonaco registry holders and dispose the JS editor whenever it was created. Swap text in JS and restore scroll, coalesce null texts, dispose the module handle, retry with backoff for about 30s and show a failed state. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 123 |
| Duplication | 4 |
🟢 Coverage 100.00% diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation Diff coverage ✅ 100.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (6aa4bc6) 18071 18048 99.87% Head commit (111b111) 18147 (+76) 18124 (+76) 99.87% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#248) 76 76 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
Split SyncAsync and OnEditorInitAsync into focused methods (Lizard), one declaration per line in the .razor.css and move the BlazorMonaco container rule to main.scss (stylelint ::deep), make _initRetryDelay readonly (S2933), drop the unused GetOptions parameter (S1172) and assign the editor through a property (S3459). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Move the null-coalescing texts and the JS-failure filter out of OnEditorInitAsync (Lizard CCN) and write the editor reference through a setter backed by a field (S3459). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
PDDiffPanel, a Monaco diff view (BlazorMonacoStandaloneDiffEditor), andMonacoLanguage.FromFileName(file name to Monaco language id).Original,Modified,FileName,Language,SideBySide(toolbar toggle),ReadOnly,Height,Theme./pddiffpanel), nav link, docs section, 31 bUnit tests and a 6-test Playwright spec (all passing locally).Note:
GenerateDocs.ps1removes unrelated hand-written PDChat sections when run, so the PDDiffPanel rows inComponentDocumentation.mdwere synced by hand.🤖 Generated with Claude Code