Repository navigation
feat: add shared API documentation contracts and AsyncAPI generation - #1
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ffb92d1c81
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25358ef3b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bdcccb8614
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Изменения
Проверка
Локально прошли restore, format, Release build и 56 тестов; покрытие исходников 100% строк и ветвей. Новые проверки воспроизвели дублирование каналов до исправления. CI и Sonar текущего коммита прошли.
Команды:
dotnet restore,dotnet format,dotnet build -c Release,dotnet test -c Release.В браузере Scalar 2.20.0 проверены три демонстрационных хаба, два метода в одном хабе, два хаба одного модуля и отдельный модуль/версия. Каналов стало 2 вместо 5 для Matchmaking и 1 вместо 2 для Battle. Replies, обычный результат, stream item и error отображаются внутри своих операций. Реальные WebSocket-вызовы и серверный стрим прошли.
Сравнение JSON до/после подтвердило полное совпадение components, ID операций и остальных полей операций, кроме перемещённых reply-ссылок. Все 191 тест SignalR с текущими исходниками общего пакета прошли.
Контракты и зависимости
ID операций, имена и ключи message-компонентов, wire targets и payload-схемы сохранены. Меняется граф документа: reply.channel и reply.messages ссылаются на существующий канал. Миграций и новых настроек нет.
Новый NuGet/API с IsAotCompatible и статической генерацией. Отдельных AOT-проектов и AOT job нет. Сначала публикация этого пакета, затем Scalar и транспортных адаптеров; зависимости ограничены 1.x.