Repository navigation
feat: glass and portal subpaths, and capped chart axis labels - #244
Conversation
An app importing by subpath had to fall back to the root entry for useGlassMaterial and PortalHost, which loads the whole library. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Axis labels sit in fixed-width gutters at fixed steps, so at the accessibility text sizes they overlapped each other or clipped. Every chart axis now caps its labels at iOS's largest non-accessibility size (1.353x). The values stay available to screen readers through each chart's accessibility data. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
The heatmap's gutters are only just big enough for its labels at the default size: a 26px weekday column and a 16px month row. At the axis cap a weekday no longer fits, so "Tue" wrapped onto two lines and the month row ran into the first row of cells. Both gutters, and the offset that centres a weekday on its row, now scale by the same capped factor as the labels. They only grow above the default text size, so the default and smaller sizes lay out exactly as before. A weekday label is also held to one line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merged — thanks @danestves, and welcome back! Really good to see you contributing again. Both fixes checked out on the simulator: the axis labels now fit at the largest text sizes, and nothing moves at the default size. The heatmap's gutters were tighter than the cap allowed (weekdays wrapped and the months ran into the cells), so I pushed a small follow-up that grows them with the labels. These will go out in the next release. |
Two fixes an app was carrying as a local patch against 0.112.0.
Glass and Portal had no subpath. An app importing by subpath had to fall back to the root entry for
useGlassMaterialandPortalHost/PortalProvider, which loads every component. Both modules are already root-public, so they are added as leaves ingenerate-subpath-exports.mjsand the exports map is regenerated. The subpath test and the README's leaf list are updated to match.Axis labels outgrew their gutters at large text sizes. Axis labels sit in fixed-width gutters at fixed steps, so at the accessibility text sizes they overlapped each other or clipped. A shared
CHART_AXIS_MAX_FONT_SCALE(1.353, iOS's largest size before the accessibility range) inprimitives/chart-accessibility.tsnow caps every axis label in all 13 charts: area, bar, bubble, bump, candlestick, heatmap, line, live-line, mirror-area, plot, pyramid, scatter and waterfall. Screen readers still get the values through each chart's accessibility data. Tooltips, headers and legends are untouched.Verified with typecheck, build,
npm test,docs:generate(no drift) andverify:package. Not checked on a device.Changes made by Claude Opus 5.5 (
claude-opus-5-5) running in Claude Code.Summary by CodeRabbit