Skip to content

Correct File Extension in IRI - #491

Open
kara-mela wants to merge 1 commit into
pan-ontologies:masterfrom
kara-mela:ISS470-file-extension-iri-check
Open

kara-mela wants to merge 1 commit into
pan-ontologies:masterfrom
kara-mela:ISS470-file-extension-iri-check

Conversation

@kara-mela

Copy link
Copy Markdown
Collaborator

Motivation

We started using the checks provided by LintedData and had to suppress several checks in the beginning in order to make our pipeline pass. We will take care of these checks one by one, activating them inorder to improve PaNET in the long run. Here we focus on the file extension in the IRI.

Modification

The check has been activated (by deleting the line in linteddata.yaml). The pipeline has been updated to use the new version of panet-build, which solves the issue.

Result

The pipeline passes.

Related Issues

closes #470

@kara-mela
kara-mela requested a review from hgoerzig September 7, 2026 09:07
@kara-mela
kara-mela force-pushed the ISS470-file-extension-iri-check branch from 9d2d754 to 16730bc Compare September 29, 2026 09:05
Motivation

We started using the checks provided by LintedData and had to suppress several checks in the
beginning in order to make our pipeline pass. We will take care of these checks one by one,
activating them inorder to improve PaNET in the long run.
Here we focus on the file extension in the IRI.

Modification

The check has been activated (by deleting the line in linteddata.yaml).
The pipeline has been updated to use the new version of panet-build, which solves the issue.

Result

The pipeline passes.
@kara-mela
kara-mela force-pushed the ISS470-file-extension-iri-check branch from 16730bc to bbda79f Compare October 2, 2026 08:00
@kara-mela

Copy link
Copy Markdown
Collaborator Author

@hgoerzig here are the detailed instructions to check if my changes are working:

  • have a clone of panet-build "parallel" to the PaNET repo
  • bring panet-build up to date (git pull)
  • terminal: chmod +x build-panet
  • go to PaNET root directory
  • bring PaNET up to date (git pull)
  • execute build-panet in terminal: ../panet-build/build-panet
  • check folder 'source' for newly created PaNET.owl
  • Download LintedData.jar from https://gitlab.com/dlr-dw/linteddata/-/releases/v3.0.0 -> Packages -> Binaries (jar)
  • copy jar to PaNET root
  • execute linter in terminal: java -jar LintedData.jar --junit linted-data.xml --config .github/linteddata.yaml source/PaNET.owl
  • inspect new file linted-data.xml -> 0 failures expected
    • this is more or less current state
  • in linteddata.yanl set FileExtensionInIriCheck to true (or delete this line) and execute linter -> 0 failure expected
    • this is the new state of PaNET after merging my request

@hgoerzig hgoerzig left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do the approval of new images in an extra PR?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileExtensionInIriCheck

2 participants