chore: remove whisper-apr — it is a standalone project - #2515
Open
noahgift wants to merge 1 commit into
Open
Conversation
Repo owner's call: whisper-apr does not belong in aprender.
It was optional in all three crates and in NO default feature set, so
nothing that ships by default loses anything:
apr-cli whisper = ["whisper-apr"]
aprender-orchestrate speech = ["whisper-apr", "native"]
aprender-rag transcription = ["dep:whisper-apr"]
aprender-rag-cli transcription = ["aprender-rag/transcription"]
root facade whisper = ["cli", "apr-cli/whisper"]
All five feature declarations, the three dependency lines, and "speech"
from `sovereign-stack` are gone, along with 4 files (~1,960 lines):
aprender-rag's transcription loader, the orchestrate demo + book page,
and apr-cli's whisper routing falsifier.
ONE JUDGEMENT CALL, because the honest answer was not simply "delete".
`/transcribe` had a `#[cfg(not(feature = "speech"))]` fallback returning
"[dry-run] Would transcribe N bytes ... Enable --features speech
for real transcription."
With `speech` gone that tells the caller to enable a feature that no
longer exists, and returns a 200 with a plausible-looking body that is
not a transcription. It now returns 501 naming whisper-apr as the
standalone tool. A route that answers is worse than one that refuses,
which is the #2495 lesson.
KEPT DELIBERATELY: `whisper_apr::` in the oracle cookbook and
recommender. Those are string literals in examples teaching users about a
separate project -- which is now exactly the right thing for them to say.
Also removed the dangling book SUMMARY link to the deleted page and
CLAUDE.md's two `apr ... whisper` examples, both of which advertised a
capability this commit removes.
Green: workspace cargo check, apr-cli 7064, aprender-rag 449,
aprender-orchestrate 6525. (An earlier orchestrate run showed 1 failure;
re-run clean at 6525/0 -- it was a flake under load 30+, not this change.
Verified before committing rather than assumed.)
Refs #2481
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo owner's decision: whisper-apr does not belong in aprender.
Contained by construction
It was optional in all three crates and in no default feature set, so nothing that ships by default loses anything:
apr-cliwhisper = ["whisper-apr"]aprender-orchestratespeech = ["whisper-apr", "native"]aprender-ragtranscription = ["dep:whisper-apr"]aprender-rag-clitranscription = ["aprender-rag/transcription"]whisper = ["cli", "apr-cli/whisper"]All five declarations, the three dependency lines, and
"speech"fromsovereign-stackare gone — plus 4 files, ~1,960 lines.One judgement call
/transcribehad a#[cfg(not(feature = "speech"))]fallback returning:With
speechremoved that tells the caller to enable a feature that no longer exists, and returns 200 with a plausible-looking body that is not a transcription.It now returns 501 naming whisper-apr as the standalone tool. A route that answers is worse than one that refuses — the #2495 lesson.
Kept deliberately
whisper_apr::references in the oracle cookbook and recommender. Those are string literals in examples teaching users about a separate project, which is now exactly the right thing for them to say.Also removed the dangling book
SUMMARY.mdlink to the deleted page, and CLAUDE.md's twoapr … whisperexamples — both advertised a capability this PR removes.Verification
Green: workspace
cargo check, apr-cli 7,064, aprender-rag 449, aprender-orchestrate 6,525.An earlier orchestrate run showed 1 failure. Re-ran clean at 6,525/0 — it was a flake under load 30+, not this change. Verified before committing rather than assumed.
Clears part of #2481 F-1: the monorepo depending on published copies of itself. whisper-apr was the transitive source of the registry
aprender/realizar/truenopulls.