test(guard): tests must not gate on paths outside the workspace - #2478
Open
noahgift wants to merge 1 commit into
Open
test(guard): tests must not gate on paths outside the workspace#2478noahgift wants to merge 1 commit into
noahgift wants to merge 1 commit into
Conversation
noahgift
force-pushed
the
fix/test-fixture-path-guard
branch
from
August 14, 2026 15:30
eb74564 to
3330189
Compare
noahgift
enabled auto-merge
August 14, 2026 15:30
noahgift
force-pushed
the
fix/test-fixture-path-guard
branch
from
August 15, 2026 09:43
3330189 to
879028c
Compare
…erywhere but one machine
The monorepo consolidated 20 sibling repos in-tree. Tests written before the
merge still gate on the OLD sibling checkouts:
let has_q4k = file_exists("/home/noah/src/realizar/src/quantize.rs");
if !has_q4k { eprintln!("SKIP - realizar not found"); return; }
realizar IS crates/aprender-serve now. That path cannot exist again on any
machine, so every test behind such a gate is permanently and silently green.
Five of them remain, in falsification_2x_ollama_tests.rs and
falsification_correctness_tests.rs, and one runs a command with
`.current_dir("/home/noah/src/realizar")`. Not one reads the file it probes --
the path exists only to decide whether to skip. F102's gate is purely
decorative: its body times two inline loops and never touches realizar at all.
They are invisible twice over: workspace-test runs `--lib`, so these integration
targets are never compiled either. A skip nobody sees, in a test nobody runs,
behind a claim somebody trusts.
Scope: 85 out-of-workspace paths across 1921 test files. Includes gates on this
repo's OWN pre-monorepo layout (`/home/noah/src/aprender/src/format/mod.rs` --
that file is `crates/aprender-core/src/format/` now).
This is a RATCHET, not a cleanup. Repointing the existing gates makes dormant
tests execute for the first time and will surface real failures; that is its own
change with room for the fallout. This stops the population growing and makes
the debt a number that can only fall.
Verified:
* case table, 3 defect shapes + 4 legitimate paths (workspace-relative, /tmp,
env var, relative). The table caught my first version being BLIND -- the
`find` pruned `tests` directories, excluding the only thing it must scan.
Fifth time a guard regex in this repo was wrong; fifth time a table caught it
and review would not have.
* mutation: add one new out-of-workspace gate -> RED, listing every violation.
Restored -> PASS.
* vacuity: fails if fewer than 200 test files are scanned, so a broken scan
cannot report clean.
Refs #2474
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
noahgift
force-pushed
the
fix/test-fixture-path-guard
branch
from
August 18, 2026 17:03
879028c to
014ef9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The monorepo consolidated 20 sibling repos in-tree. Tests written before the
merge still gate on the OLD sibling checkouts:
realizar IS crates/aprender-serve now. That path cannot exist again on any
machine, so every test behind such a gate is permanently and silently green.
Five of them remain, in falsification_2x_ollama_tests.rs and
falsification_correctness_tests.rs, and one runs a command with
.current_dir("/home/noah/src/realizar"). Not one reads the file it probes --the path exists only to decide whether to skip. F102's gate is purely
decorative: its body times two inline loops and never touches realizar at all.
They are invisible twice over: workspace-test runs
--lib, so these integrationtargets are never compiled either. A skip nobody sees, in a test nobody runs,
behind a claim somebody trusts.
Scope: 85 out-of-workspace paths across 1921 test files. Includes gates on this
repo's OWN pre-monorepo layout (
/home/noah/src/aprender/src/format/mod.rs--that file is
crates/aprender-core/src/format/now).This is a RATCHET, not a cleanup. Repointing the existing gates makes dormant
tests execute for the first time and will surface real failures; that is its own
change with room for the fallout. This stops the population growing and makes
the debt a number that can only fall.
Verified:
env var, relative). The table caught my first version being BLIND -- the
findprunedtestsdirectories, excluding the only thing it must scan.Fifth time a guard regex in this repo was wrong; fifth time a table caught it
and review would not have.
Restored -> PASS.
cannot report clean.
Refs #2474
Co-Authored-By: Claude Opus 5 noreply@anthropic.com