rust - make proto file ordering determinist - #636
Open
Devansh-567 wants to merge 1 commit into
Open
Devansh-567 wants to merge 1 commit into
Devansh-567 wants to merge 1 commit into
Conversation
Signed-off-by: Devansh-567 <devansh.jay.singh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort the .proto files discovered by WalkDir before compiling them in the Prost and Tonic build scripts.
WalkDir doesn't guarantee the order in which files are returned. That means the order passed to the protobuf compiler can depend on the filesystem or environment.
Sorting the list gives us a consistent order across machines and CI runs, making the generated output more reproducible.
Changes
No other build logic or dependencies are changed.