Remove stray println! from merge code#1034
Open
danieleades wants to merge 1 commit into
Open
Conversation
Fold the schema JSON into the unimplemented! panic message instead of printing it to stdout, so library consumers (proc-macro and CLI) don't get raw JSON noise on stdout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typify-impl/src/merge.rs contained a leftover debug
println!that dumps the raw subschema JSON to stdout whenever an if/then/else schema is encountered, polluting the stdout of any build using the macro or CLI. This folds that JSON into theunimplemented!panic message instead, so the diagnostic is preserved where it is actually seen. No functional change otherwise.