Restrict TypeSpace::break_cycles to crate visibility#1029
Open
danieleades wants to merge 1 commit into
Open
Conversation
break_cycles is an internal helper that operates on raw ranges of internal type IDs. It was unintentionally exposed as public API: inherent-impl method visibility ignores module privacy, so `pub` in the private cycles module made it visible to external callers. It cannot be used meaningfully outside the crate, and calling it with arbitrary ranges could corrupt the type space. All call sites are internal, so mark it pub(crate).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Changes
TypeSpace::break_cyclesfrompubtopub(crate).Why
break_cycleslives in the privatecyclesmodule, but inherent-impl method visibility ignores module privacy, so thepubmarker made it part of typify-impl's public API (it shows up on docs.rs). The method takes a rawRange<u64>of internal type IDs, so it can't be used meaningfully by external callers, and invoking it with arbitrary ranges could corrupt the type space. All call sites are internal to the crate.Notes
grep -rn break_cyclesconfirms the only caller is intypify-impl/src/lib.rs; nothing in thetypifyfacade crate,typify-macro, orcargo-typifyuses it.