Audit log - #2860
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Can't repro locally, but this happened twice in CI so it's probably not a fluke. 
|
fakemonster
left a comment
fakemonster
left a comment
There was a problem hiding this comment.
a few more observations. just like in social media, infinite scroll leads to pain!
The previous attempt to read an error message would never succeed, and since errors are generally happening at the bottom of the page, I moved the error message down there. If we get rid of interval refreshing, _all_ errors will be down there!
Doesn't really make sense when you have pagination; you don't want to refetch every page automatically, nor do you want to drop everything past the first page.
|
i think these are the issues we would want to create for potential followup:
|
Maybe this had some utility originally, but when it caused a merge conflict I started to wonder why it needed to be there in the first place. The virtual list wouldn't need it, nor would the side drawer.
|
There's a statefulness implied by the listbox that I don't love. There's no difference in practice between having 
|
3268c54 to
e9bd2e1
Compare
|
Low priority because it only happens on the preview, but the sticky header goes under the top bar when I scroll. 2026-08-27-sticky-audit-log-header-bug.mp4 |
4 participants
https://console-git-audit-log-oxidecomputer.vercel.app/system/audit-log
Copied from #2849, which I accidentally merged and couldn't reopen even after I fixed
main.Still very rough, but has been a helpful exercise in working through some of the design due to the sheer amount of information and differing layout from other pages.
https://github.com/user-attachments/assets/84cbb9f6-d22b-4e64-9b1d-e39d74d22902
Stubbing out based on oxidecomputer/omicron#7339.
Uses Tanstack Virtual. On testing with > 500 lines without virtualisation it starts to get a bit chunky especially if you're interacting with the page (e.g. opening the row).
Hoping that silo name and actor display name can be plumbed through so those are hard-coded for now.
Still needs: