feat: create a share with users and groups on an oCIS server

[joragua]

Related Issues

App: #4875 #4917

• Add changelog files for the fixed issues in folder changelog/unreleased. More info here
• Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

---

QA

Reports:

• (1) Accessibility: add new member feat: create a share with users and groups on an oCIS server #4952 (comment)
• (2) List of permissions does not load sometimes feat: create a share with users and groups on an oCIS server #4952 (comment)

[jesmrec]

Cool, great job @joragua!

Let's move this to QA

[jesmrec]

(1)

1. Enable Talkback
2. Open Share and click on +

Current: Talkback says Add new member

Expected: Share with people

Xiaomi Redmi 13, Android 15
3b3534cf2

[jesmrec]

(2)

That one comes from the 1st draft of the E2E tests for sharing NG.

After selecting the sharee, sometimes, the list of permissions is not loaded. I wasn't able to reproduce in a real device, but, it might be caused because the automatic way is faster in performing requests. Check the following video:

Screen_recording_20260904_100347-edit.mp4

is there something that could be improved there?

PD: i asked claude and it said that:

Root Cause

  Race condition in AddGraphShareFragment.subscribeToViewModels() (lines 122–124):

  val currentPermissions = (graphShareViewModel.shares.value?.peekContent() as? UIResult.Success)?.data
  roles = currentPermissions?.roles ?: emptyList()

  This reads shares.value synchronously as a one-time snapshot. The flow is:

  1. GraphShareFragment triggers getGraphShares() only after getRolesAsyncUseCase succeeds (see observeRoles() line 119).
  2. When a human taps "Add member", both roles and shares have already loaded → snapshot is non-null → works.
  3. When an automated test navigates faster, AddGraphShareFragment is created before the network call for shares finishes → shares.value is null → roles = emptyList().

  The fragment never subscribes to graphShareViewModel.roles or .shares to reactively update rolesAdapter once the data arrives. The list stays empty forever.

  Secondary bug: SpaceRolesAdapter.setRoles() (line 86–88) and setSelectedRole() (line 90–92) don't call notifyDataSetChanged(), so even if the data were set later, the RecyclerView would not redraw.

and that was the suggested change in AddGraphShareFragment.kt

      142 +        collectLatestLifecycleFlow(graphShareViewModel.roles) { event ->                                                                                                                                                             
      143 +            event?.let {                                                                                                                                                                                                             
      144 +                when (val uiResult = event.peekContent()) {                                                                                                                                                                          
      145 +                    is UIResult.Success -> {                                                                                                                                                                                         
      146 +                        uiResult.data?.let { fetchedRoles ->                                                                                                                                                                         
      147 +                            roles = fetchedRoles                                                                                                                                                                                     
      148 +                            rolesAdapter.setRoles(roles)                                                                                                                                                                             
      149 +                        }                                                                                                                                                                                                            
      150 +                    }                                                                                                                                                                                                                
      151 +                    is UIResult.Loading -> { }                                                                                                                                                                                       
      152 +                    is UIResult.Error -> Timber.e(uiResult.error, "Failed to retrieve platform roles")                                                                                                                               
      153 +                }                                                                                                                                                                                                                    
      154 +            }                                                                                                                                                                                                                        
      155 +        } 

and in SpaceRolesAdapter.kt

      86      fun setRoles(roles: List<OCRole>) {
      87          this.roles = roles
      88 +        notifyDataSetChanged()                                                                                                                                                                                                        
      89      }
      90  
      91      fun setSelectedRole(id: String) {
      92 +        val previousId = selectedRoleId                                                                                                                                                                                               
      93          this.selectedRoleId = id
      94 +        previousId?.let { notifyItemChanged(roles.indexOfFirst { it.id == previousId }) }                                                                                                                                             
      95 +        notifyItemChanged(roles.indexOfFirst { it.id == id })                                                                                                                                                                         
      96      }
      97 

in case it works, should it be added to the refactor for space management?