fix: remove stray $ from 'Can't find directory' error message - #17
Open
Avicennasis wants to merge 1 commit into
Open
fix: remove stray $ from 'Can't find directory' error message#17Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
The interpolated string in FileListenerWorker.ListenOnDirectory has an
extra $ before the placeholder, so the message reaches the caller as
"Can't find directory $C:\path" instead of "Can't find directory C:\path".
The sibling message on line 138 ($"Exception: {ex}") shows the intended form.
Message text only - no functional change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 1 typo in a user-facing error message:
$"Can't find directory ${path}"->$"Can't find directory {path}"ListenOnDirectorybuilds its not-found message with a C# interpolated string, but there is an extra$in front of the placeholder. In an interpolated string that$is a literal character, so the message the caller actually receives isCan't find directory $C:\some\pathrather thanCan't find directory C:\some\path. The sibling message a few lines down in the same method ($"Exception: {ex}", line 138) shows the intended form, and this is the only${in the repository's C# sources.Message text only - no functional change, no identifier renamed, and the string is not asserted anywhere in
unittest/.Not included
A scan also flagged several misspelled identifiers in this plugin -
_listenTaskes,warpper,DirctoryExistsand theSignitureHelperclass inplugins/downloader/Security/. Those are left alone deliberately: renaming symbols is out of scope for a typo fix and is a maintainer's call. Happy to follow up with a separate rename PR if that would be useful.