Repository navigation
fix: rollout findings of v0.3.0 (v0.3.1) - #4
Merged
Merged
Conversation
- DS-SEC accepts "Latest release (v1.4.x)"; the parenthesised version must be the latest minor, as a bare "v1.4.x" must. - goapi: addTests parses comments, so a //go:build ignore _test.go file is skipped and its test functions and imports are not recorded. - goapi: the ExportedNames doc comment no longer claims struct fields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three bugs found during the org rollout of v0.3.0.
Fixes
| Latest release (v1.4.x) | Yes |was rejected.latestREnow allows an optional parenthesised suffix. A bare "Latest release" still names the latest minor, whatever it is. With a version in parentheses, that version must matchsupportedREand be the latest minor, the same rule as a barev1.4.xcell (internal/check/versions.go, new helperssupportsMinorandlatestRow).Test:
TestGitChecks(internal/cli/cli_test.go).Latest release (v0.3.x),(0.3.x)andLatest release(v0.3.x)pass.(v0.2.x),(v0.3.xy),(soon)and()are reported._test.gofiles were still recorded.addTestsparsed withoutparser.ParseComments, soignored(f)never saw//go:build ignore. It now parses withSkipObjectResolution|ParseComments.Test:
TestLoadImportsAndTests(internal/goapi/goapi_test.go) adds anignored_test.gowithTestIgnoredand anignoredonlyimport. Neither may appear inTestsorImports.ExportedNamesdoc comment claimed struct fields. The function never added fields, and its only caller,depHas, looks uppkg.Name. The comment now matches what the function does.Test:
TestExportedNamesnow asserts thatFieldis absent. This pins the documented contract. It passes both before and after the change, because only the comment changed.RELEASE.md gets a
## v0.3.1section (unreleased).Checks
go vet ./...: cleango test -race ./...: passgolangci-lint run ./...: 0 issuesmake docs-check: passotfabric-policy check: 0 must-fail, result compliant🤖 Generated with Claude Code