Archive osac-ui: merged into osac mono-repo - #228
Merged
Merged
Conversation
osac-ui's full commit history is being merged into the osac mono-repo. Marking it archived and lock_branch, matching the same pattern already used for fulfillment-service, osac-operator, osac-aap, osac-installer, and osac-csi-driver after their own mono-repo merges. Signed-off-by: Elior Erez <eerez@redhat.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
eliorerz
added a commit
to osac-project/osac
that referenced
this pull request
Sep 18, 2026
## Summary Merges `osac-project/osac-ui`'s full commit history (1106 commits, verified against its live `main` HEAD immediately before archival — nothing landed in the gap) into this repo under `osac-ui/`, using `git filter-repo --to-subdirectory-filter osac-ui` + a history-preserving merge. `osac-project/osac-ui` is now archived (`osac-project/github-config#228`). This is phase 1 of the move: get the code and history in safely, without letting it interfere with or be interfered with by anything already here. Making osac-ui's chart/images follow the same build-and-release patterns as every other component is a deliberate follow-up, not part of this PR. ## What's isolated, and how - osac-ui's own CI (`lint`, `test`, `typecheck`, a PR-time container sanity build, and the two tag-triggered publish workflows) is relocated from `osac-ui/.github/workflows/` — where GitHub Actions never reads it — to this repo's root `.github/workflows/`, prefixed `osac-ui-*`, each scoped with `paths: ['osac-ui/**']`. Nothing here runs unless an osac-ui file actually changed. - Every existing mono-repo workflow (`unit-tests.yml`, `integration-tests.yml`, `helm-lint.yaml`, `check-pull-request.yaml`, `check-generated-code.yaml`, etc.) already gates on an explicit per-component path/matrix list that doesn't mention `osac-ui` — confirmed by reading each one — so they're unaffected by this merge without needing any changes. - `check-floating-tags.yaml` was the one exception: osac-ui had its own near-duplicate of this repo's existing workflow of the same name, using a strictly-smaller copy of the same script. Folded osac-ui's chart values into the existing per-component list instead of carrying over a second copy of both files. - Added `osac-ui/charts/.*/templates/` to the yamllint exclude, matching every sibling component's existing Helm-templates exclusion. - The two publish workflows (`osac-ui-publish-image.yaml`, `osac-ui-publish-charts.yaml`) are carried over structurally intact but functionally dormant: their tag-push trigger assumed a bare `vX.Y.Z` tag on osac-ui's own repo, which won't happen here — this repo's `<component>/vX.Y.Z` tagging convention needs a deliberate follow-up, not a guess made in this PR. `IMAGE_NAME`/`REPO` are hardcoded to `osac-project/osac-ui` (rather than derived from `${{ github.repository }}`, which now resolves to `osac-project/osac`) so neither workflow can accidentally publish to the wrong image path if manually triggered before that follow-up lands. ## Repo-wide impact checked `pre-commit.yaml` runs `pre-commit run --all-files` on **every** PR in this repo, regardless of what it touches -- unlike every other workflow checked above, it isn't path-scoped. Ran it locally against this branch: `fix end of files` failed on 197 of osac-ui's files (mostly generated protobuf TS, plus a couple of docs/chart files) that had a trailing blank line or a missing final newline. Without fixing this, the `pre-commit` check would fail on the *next PR anyone opens in this repo*, whether or not it touches osac-ui, until someone fixed it. Fixed in this PR -- confirmed clean re-run afterward. ## Also in this PR - Closed `#1026` (the osac-ui version auto-bump workflow) — obsolete once osac-ui lives here. ## Testing - Commit count and last-5-commits (messages + timestamps) verified identical between the live `osac-ui` repo and the rewritten history immediately before merging, and again immediately before archiving. - `yamllint --strict` (this repo's own `.yamllint.yaml`) passes clean on every new/modified workflow file. - All new/modified YAML parses correctly. Signed-off-by: Elior Erez <eerez@redhat.com> --------- Signed-off-by: Elay Aharoni <elayaha@gmail.com> Signed-off-by: Chai Bot <ship-help-github@redhat.com> Signed-off-by: Rastislav Wagner <rawagner@redhat.com> Signed-off-by: batzionb <brotman@redhat.com> Signed-off-by: redhat-chai-bot <redhat-chai-bot@users.noreply.github.com> Signed-off-by: Liat Berkovich <lberkovi@redhat.com> Signed-off-by: Chai Bot <chai-bot@redhat.com> Signed-off-by: red-hat-konflux-kflux-prd-rh02[bot] <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com> Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com> Signed-off-by: Elior Erez <eerez@redhat.com> Signed-off-by: Claude Code <noreply@anthropic.com> Co-authored-by: openshift-merge-bot[bot] <148852131+openshift-merge-bot[bot]@users.noreply.github.com> Co-authored-by: Elay Aharoni <elayaha@gmail.com> Co-authored-by: Elay Aharoni <eaharoni@redhat.com> Co-authored-by: Chai Bot <ship-help-github@redhat.com> Co-authored-by: Jeffrey Phillips <jephilli@redhat.com> Co-authored-by: Rastislav Wagner <rawagner@redhat.com> Co-authored-by: batzionb <brotman@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Chai Bot <chai-bot@redhat.com> Co-authored-by: aipcc-bot <aipcc-bot@redhat.com> Co-authored-by: Liat Berkovich <lberkovi@redhat.com> Co-authored-by: red-hat-konflux-kflux-prd-rh02[bot] <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com> Co-authored-by: openshift-ci[bot] <75433959+openshift-ci[bot]@users.noreply.github.com> Co-authored-by: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
osac-ui's full commit history (1106 commits, verified againstmain's live HEAD immediately before this PR) is being merged into theosac-project/osacmono-repo underosac-ui/.Marks it
archived = true/lock_branch = true, the same pattern already applied tofulfillment-service,osac-operator,osac-aap,osac-installer, andosac-csi-driverafter their own mono-repo merges.Sequencing
This should merge before (or atomically with) the mono-repo PR bringing
osac-ui's history in, so nothing new lands inosac-uiafter the history snapshot was taken.Signed-off-by: Elior Erez eerez@redhat.com
Summary
repo_osac_uiinrepositories.tf.archived = trueandlock_branch = true.Risk classification
risk:ship — The change only updates repository metadata and supports the mono-repository migration. It does not change runtime behavior or application data.
It does not qualify as risk:show because it does not change user-visible behavior. It does not qualify as risk:ask because it does not change runtime logic, security controls, or data handling.