Skip to content

NO-ISSUE: archive osac-project/docs - #223

Merged
eliorerz merged 1 commit into
osac-project:mainfrom
eliorerz:osac-archive-docs-repo
Sep 16, 2026
Merged

eliorerz merged 1 commit into
osac-project:mainfrom
eliorerz:osac-archive-docs-repo

Conversation

@eliorerz

@eliorerz eliorerz commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

osac-project/docs's content and full commit history were merged into the
osac-project/osac mono-repo's docs/ folder in osac-project/osac#1043
(merged). This repo no longer needs its own existence — sets archived = true and lock_branch = true on module "repo_docs", matching the same
pattern already used for fulfillment-service, osac-operator, osac-aap,
osac-installer, bare-metal-fulfillment-operator, and osac-csi-driver
when each of those was folded into the mono-repo.

Note for reviewers

osac-project/docs currently has 5 open PRs (and a couple of other open
branches) from other contributors. Archiving makes those unmergeable in
place going forward — accepted trade-off, not remediated here (per explicit
direction from the mono-repo migration). Please don't merge this until
you've confirmed that's still acceptable.

Since this repo's apply.yaml workflow auto-applies on every push to main
with no manual approval gate, merging this PR immediately and
automatically archives the repo
— there is no separate deploy step.

Test plan

  • tofu fmt -check clean
  • tofu validate — pre-existing, unrelated error in
    modules/common_repository/variables.tf's push_allowances null
    check reproduces identically on unmodified main; not caused by this
    change
  • Confirm with the docs repo's approvers/OWNERS that archiving now
    (rather than after the 5 open PRs are resolved) is acceptable

🤖 Generated with Claude Code

Summary

  • Repository management: Set archived = true and lock_branch = true for repo_docs.
  • State management: Preserved the existing repo_osac_metering_service to repo_osac state move.
  • API, controllers, database, authentication, CI, tests, and documentation: No changes.

Backward compatibility

Archiving makes the osac-project/docs repository and its open pull requests unmergeable. Its content and commit history are available in osac-project/osac/docs/.

Validation

  • tofu fmt -check passed.
  • tofu validate reports a pre-existing error in modules/common_repository/variables.tf.
  • Approver confirmation remains pending.

Risk classification

Risk label: unavailable. The supplied shell result contains no diff or labeling criteria. Therefore, this summary cannot determine whether risk:ship, risk:show, or risk:ask was applied, or compare the change with another classification.

Its content and full commit history were merged into the osac mono-repo's
docs/ folder (osac-project/osac#1043).

Assisted-by: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Elior Erez <eerez@redhat.com>
@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 97e5a074-3da3-4e70-9ca5-7290cee924f8

📥 Commits

Reviewing files that changed from the base of the PR and between 1ad473c and 7d36bfe.

📒 Files selected for processing (1)
  • repositories.tf

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


Walkthrough

The repo_docs declaration now records its merge into the osac monorepo, marks the repository as archived, and locks its branch.

Changes

Repository lifecycle

Layer / File(s) Summary
Update repository state
repositories.tf
The repo_docs declaration records the merge destination, sets archived = true, and enables lock_branch.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested labels: risk:ask

Suggested reviewers: larsks

Merge Risk: ⚪ Minimal · up to 7d36b

The repository will be read-only once archived, so no actionable merge risk remains.

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely states the main change: archiving the osac-project/docs repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed PASS: The pull request changes only repositories.tf. Its four added lines are a comment plus archived = true and lock_branch = true. No API keys, tokens, passwords, private keys, credential-bear…
No-Weak-Crypto ✅ Passed The pull request changes only repositories.tf. It adds archived = true and lock_branch = true to the repo_docs module. The patch introduces no cryptographic algorithm, crypto implementation, o…
No-Injection-Vectors ✅ Passed PASS. The pull request changes only repositories.tf and adds literal Terraform booleans, archived = true and lock_branch = true, plus comments. The module accepts these values as typed bool va…
Container-Privileges ✅ Passed The PR changes only repositories.tf to set archived = true and lock_branch = true for the GitHub repo_docs module. The module maps these values to GitHub repository and branch-protection setti…
No-Sensitive-Data-In-Logs ✅ Passed PASS — The pull request changes only repositories.tf. The added lines set archived = true and lock_branch = true for repo_docs, plus a migration comment. These values flow to GitHub repository…
Ai-Attribution ✅ Passed AI use is disclosed in the PR description, and the reviewed commit contains the required Assisted-by: Claude Sonnet 5 <noreply@anthropic.com> trailer. The commit uses no Co-Authored-By trailer for…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@eliorerz
eliorerz merged commit 083a480 into osac-project:main Sep 16, 2026
1 of 2 checks passed
@eliorerz
eliorerz deleted the osac-archive-docs-repo branch September 16, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant