fix: only one rate limit doc - #2699
Conversation
📝 WalkthroughWalkthroughThe Operations sidebar now links directly to the project and endpoint rate-limit guides. Temporary redirects preserve access to the legacy and new rate-limit guide URLs. ChangesRate-limit navigation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟡 Not ready to approve
The PR introduces at least one likely-broken relative doc link and uses non-permanent redirects for removed pages, which should be corrected before merge.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR consolidates the “Rate limits” documentation into a single page and removes the legacy/new split, updating navigation and adding redirects so old URLs still resolve.
Changes:
- Removes
rate-limits-legacyandrate-limits-newdocs and folds key guidance intodocs/guides/rate-limits.mdx. - Updates the sidebar to list the remaining subpages directly under “Rate limits”.
- Adds Vercel redirects from the removed doc routes to the unified rate limits page.
File summaries
| File | Description |
|---|---|
| vercel.json | Adds redirects from removed rate-limit pages to the unified rate-limit doc. |
| sidebars.ts | Removes the legacy/new rate limits entries and keeps only the remaining subpages. |
| docs/guides/rate-limits.mdx | Rewrites the main rate limits page to be the single source of truth and adds client-handling guidance. |
| docs/guides/rate-limits-new.mdx | Deletes the “new” rate limits page (content consolidated into the main page). |
| docs/guides/rate-limits-legacy.mdx | Deletes the “legacy” rate limits page (content consolidated into the main page). |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 4
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
Further comments
Summary by CodeRabbit