refactor(react): remove low-risk lint suppressions - #882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ORGII carries stale ESLint suppression entries and low-risk React dependency suppressions that obscure the current lint signal. Several dependency omissions only involve stable refs or setters, while a component-local pure helper creates three avoidable exhaustive-deps suppressions. The storage reset directive also suppresses one rule that no longer applies alongside one rule that remains required.
Solution
Potential risks
The added dependencies rely on the existing stable-ref and stable-setter contracts. If a caller replaces a ref object identity, the associated effect will now re-run or re-register, which is the correct dependency behavior but is a lifecycle path to watch. No public API, persistence format, IPC contract, dependency, or user-visible markup changes are included. Rollback is a commit revert. Runtime profiling and visual screenshots were not useful for this source-only lint cleanup, so no performance improvement is claimed.
Verification
git diff --name-only -- src | rg "\.(tsx?|jsx?)$" | xargs node_modules/.bin/eslint --report-unused-disable-directives --format unix— passed with no findings on all changed source files.pnpm typecheck— passed.pnpm exec vitest run src/engines/SessionCore/utils/__tests__/waitForSnapshotChange.test.ts src/modules/WorkStation/CodeEditor/hooks/sourceControl/__tests__/gitFilesDerivation.test.ts src/components/ComposerInput/__tests__/cutHandler.test.ts— 3 files passed, 37 tests passed.git diff --check— passed.The full test suite and a redundant full-repository ESLint scan were not run; changed-file lint, full TypeScript, and focused tests were used for this low-risk cleanup.