Skip to content

fix(node): sign benchmark extrinsics with the funded sr25519 //Bob and derive its account through the runtime's signer — benchmark overhead/extrinsic no longer fail with BadProof #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nol4lej merged 1 commit into from
Oct 22, 2026
Merged

fix(node): sign benchmark extrinsics with the funded sr25519 //Bob and derive its account through the runtime's signer — benchmark overhead/extrinsic no longer fail with BadProof #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions template/node/src/benchmarking.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,12 @@ use scale_codec::Encode;
use orbinum_runtime::{self as runtime, AccountId, Balance, BalancesCall, SystemCall};
use sc_cli::Result;
use sc_client_api::BlockBackend;
use sp_core::{ecdsa, Pair};
use sp_core::{sr25519, Pair};
use sp_inherents::{InherentData, InherentDataProvider};
use sp_runtime::{
generic::Era, traits::IdentifyAccount, MultiSigner, OpaqueExtrinsic, SaturatedConversion,
generic::Era,
traits::{IdentifyAccount, Verify},
OpaqueExtrinsic, SaturatedConversion,
};

use crate::service::Client;
Expand Down Expand Up @@ -40,7 +42,7 @@ impl frame_benchmarking_cli::ExtrinsicBuilder for RemarkBuilder {
}

fn build(&self, nonce: u32) -> std::result::Result<OpaqueExtrinsic, &'static str> {
let acc = ecdsa::Pair::from_string("//Bob", None).expect("static values are valid; qed");
let acc = sr25519::Pair::from_string("//Bob", None).expect("static values are valid; qed");
let extrinsic: OpaqueExtrinsic = create_benchmark_extrinsic(
self.client.as_ref(),
acc,
Expand Down Expand Up @@ -83,7 +85,7 @@ impl frame_benchmarking_cli::ExtrinsicBuilder for TransferKeepAliveBuilder {
}

fn build(&self, nonce: u32) -> std::result::Result<OpaqueExtrinsic, &'static str> {
let acc = ecdsa::Pair::from_string("//Bob", None).expect("static values are valid; qed");
let acc = sr25519::Pair::from_string("//Bob", None).expect("static values are valid; qed");
let extrinsic: OpaqueExtrinsic = create_benchmark_extrinsic(
self.client.as_ref(),
acc,
Expand All @@ -105,7 +107,7 @@ impl frame_benchmarking_cli::ExtrinsicBuilder for TransferKeepAliveBuilder {
/// Note: Should only be used for benchmarking.
pub fn create_benchmark_extrinsic(
client: &Client,
sender: ecdsa::Pair,
sender: sr25519::Pair,
call: runtime::RuntimeCall,
nonce: u32,
) -> runtime::UncheckedExtrinsic {
Expand Down Expand Up @@ -155,8 +157,8 @@ pub fn create_benchmark_extrinsic(

runtime::UncheckedExtrinsic::new_signed(
call,
MultiSigner::Ecdsa(sender.public()).into_account(),
runtime::Signature::Ecdsa(signature),
<runtime::Signature as Verify>::Signer::from(sender.public()).into_account(),
runtime::Signature::Sr25519(signature),
extra,
)
}
Expand Down
Loading