[nol4lej]

Summary

chain_isValidator compared the account against pallet_aura::Authorities, the validators' Aura keys. Since spec 19 a validator is its account: an operator that registered its session keys from its account, with a key that is not the account, was reported as not a validator.

Fixed

• chain_isValidator reads pallet_session::Validators (validator accounts) at the best block.
• Decoding moves to a pure contains_validator using decode_all: a truncated value or one with trailing bytes is an InternalError, never a partial match.

Documentation

• privacy module docs list privacy_getSubtreeRoots, state that every endpoint reads the best block, and describe the proof gate as implemented: proof_slots (half the cores) at once, then a queue bounded by MAX_QUEUED_PROOFS and MAX_PROOF_WAIT. The docs cited MAX_CONCURRENT_PROOFS, which no longer exists.
• The crate README documents chain_isValidator against Session::Validators.

Version

fc-rpc-v2 2.0.0-dev → 2.0.1-dev, with a new CHANGELOG.md.

Testing

• cargo test -p fc-rpc-v2 (50): storage key layout; absent value, empty set, member, non-member, truncated value, trailing bytes.
• cargo clippy -D warnings, cargo fmt --check.
• --dev node (spec 20): chain_isValidator is true for Alice and false for Bob.