Repository navigation
feat(validator): add SYNC_MODE so a fresh validator can warp sync - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6 - same idea, opt-in instead of hardcoded.
--sync warplets a brand new validator prove finality and fetch the latest state instead of replaying every block. Two things keep it from being a safe default:Can't use warp sync mode with a partially synced database. Reverting to full sync mode.So it goes behind
${SYNC_MODE}, empty by default, same pattern asPUBLIC_ADDRandRESERVED_NODES. Bootstrapping a new validator setsSYNC_MODE=--sync warp; existing ones are untouched.Validators only.
rpcandindexer-rpcrun--blocks-pruning archive, and an archive node exits at startup withWarp sync doesn't work for archive nodesand crash-loops underrestart: unless-stopped.Verified against
ghcr.io/orbinum/node:testnet-latest(0.2.0): empty${SYNC_MODE}leaves no stray args,--sync warpsplits correctly, warp engages on a fresh volume, is ignored once finalized state exists, and is fatal on an archive node.