Skip to content

[FSSDK-12868] update version assertions in tests #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raju-opti merged 1 commit into from
Jul 8, 2026
Merged

[FSSDK-12868] update version assertions in tests #1165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/index.browser.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ describe('javascript-sdk (Browser)', function() {
});

assert.instanceOf(optlyInstance, Optimizely);
assert.equal(optlyInstance.clientVersion, '6.4.0');
assert.equal(optlyInstance.clientVersion, packageJSON.version);
});

it('should set the JavaScript client engine and version', function() {
Expand Down
3 changes: 2 additions & 1 deletion lib/index.node.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import sinon from 'sinon';

import Optimizely from './optimizely';
import testData from './tests/test_data';
import packageJSON from '../package.json';
import * as optimizelyFactory from './index.node';
import configValidator from './utils/config_validator';
import { getMockProjectConfigManager } from './tests/mock/mock_project_config_manager';
Expand Down Expand Up @@ -88,7 +89,7 @@ describe('optimizelyFactory', function() {
});

assert.instanceOf(optlyInstance, Optimizely);
assert.equal(optlyInstance.clientVersion, '6.4.0');
assert.equal(optlyInstance.clientVersion, packageJSON.version);
});
// TODO: user will create and inject an event processor
// these tests will be refactored accordingly
Expand Down
2 changes: 1 addition & 1 deletion lib/index.react_native.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ describe('javascript-sdk/react-native', () => {
expect(optlyInstance).toBeInstanceOf(Optimizely);
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
expect(optlyInstance.clientVersion).toEqual('6.4.0');
expect(optlyInstance.clientVersion).toEqual(packageJSON.version);
});

it('should set the React Native JS client engine and javascript SDK version', () => {
Expand Down
Loading