chore: update whisper.cpp pin to 1.9.4-dev (stream-pcm de8fb5fd) - #13
Merged
Merged
Conversation
Moves the pinned rmorse/whisper.cpp stream-pcm fork from ddfe1196 (v1.8.6) to de8fb5fd (tag v1.9.4-dev-stream-pcm), based on upstream master after v1.9.3. whisper.h changes in this range are additive only, so no binding or API changes are needed. Parakeet and the new VAD timestamp/segment accessors are left for a follow-up feature branch. Picks up the upstream whisper_full_parallel timestamp overflow fix (ggml-org/whisper.cpp#4044).
Drop the whisper_full_parallel fix entry: WhisperState::full_parallel reads results from its own state while upstream writes them to the context's default state, so the upstream fix never reached crate users (to be fixed separately). Document user-visible upstream behaviour changes in the pinned range and why the new VAD accessors are not exposed.
whisper.cpp's built-in whisper_full VAD does not run for whisper_full_with_state, which the crate uses for all transcription (ggml-org/whisper.cpp#3423). Point users at WhisperVadProcessor, EnhancedWhisperVadProcessor and WhisperStreamPcm::with_vad instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rmorse/whisper.cppstream-pcmfork fromddfe1196(v1.8.6) tode8fb5fd(tagv1.9.4-dev-stream-pcm), based on upstreammasterafterv1.9.3(ggml0.25.1).build.rstarball fallback, the workspaceCargo.tomlcomment, and all three README headers.[Unreleased]CHANGELOG entries, including user-visible upstream behaviour changes in this range.Notes
whisper.hchanges in this range are additive only (VAD-mapped token timestamps, internal VAD segment accessors), so no binding or Rust API changes were needed for the pin itself.whisper_full/whisper_full_parallel, which never runs forwhisper_full_with_state(the path this crate uses). Tracked upstream in Fixed VAD to work when using whisper_full_with_state ggml-org/whisper.cpp#3423.parakeetlibrary and header. It is not bound or linked yet; Parakeet is planned for a follow-upfeat/branch.Picks up whisper : fix int overflow in whisper_full_parallel chunk offsets ggml-org/whisper.cpp#4044 (: removed from the CHANGELOG.whisper_full_paralleltimestamps)WhisperState::full_parallelreads results from its own state while upstream writes them to the context's default state, so that fix never reached crate users. This and other existing bugs found during review (segment times are centiseconds labelled as ms, danglingsuppress_regex/prompt_tokenspointers, unchecked getter indices) will be fixed in a separatefix/PR.build.rswere already out of date before this pin (not caused by it); they will be replaced separately.Path::to_str().Validation
Windows / MSVC, with test models from
cargo xtask test-setup:cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo clippy -p whisper-cpp-plus --all-targets --features async -- -D warningscargo test --workspace -- --test-threads=1: 118 passed, none skippedcargo test -p whisper-cpp-plus --features async -- --test-threads=1: 106 passed, none skippedmacOS / Metal validation is left to the PR CI job. The follow-up commit only changes
CHANGELOG.md.