Skip to content

state: remount the root filesystem read-only before halting #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
graysky2 wants to merge 1 commit into from
Closed

state: remount the root filesystem read-only before halting #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions state.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

#include <fcntl.h>
#include <pwd.h>
#include <sys/mount.h>
#include <sys/reboot.h>
#include <stdio.h>
#include <stdlib.h>
Expand Down Expand Up @@ -184,6 +185,8 @@ static void state_enter(void)
break;

case STATE_HALT:
/* logd is gone by now, log to the console instead */
ulog_open(ULOG_STDIO, LOG_DAEMON, "procd");
// To prevent killed processes from interrupting the sleep
signal(SIGCHLD, SIG_IGN);
LOG("- SIGTERM processes -\n");
Expand All @@ -195,6 +198,17 @@ static void state_enter(void)
sync();
sleep(1);
#ifndef DISABLE_INIT
/*
* sync() writes the data back, but does not leave the root
* filesystem clean: a journalling filesystem only commits its
* superblock on remount or unmount, and the remount is only
* possible now that no process is left to hold a file on it
* open for writing. The root of a container is the host's.
*/
if (!is_container() &&
mount(NULL, "/", NULL, MS_REMOUNT | MS_RDONLY, NULL))
ERROR("failed to remount / read-only: %m\n");

perform_halt();
#else
exit(EXIT_SUCCESS);
Expand Down