oph5spdtst: add package by AzulEterno · Pull Request #30529 · openwrt/packages

AzulEterno · 2026-09-14T15:50:48Z

Add oph5spdtst as an HTML5 speed-test payload service for OpenWrt. This base package installs the service and UCI configuration only; web assets are installed by the separate luci-app-oph5spdtst package.

Package details

Maintainer: @AzulEterno

Provides the payload service used by the oph5spdtst local HTML5 speed-test frontend.

Testing

Built and package-checked on ImmortalWrt 24.10, mediatek/mt7981.
Runtime verified on CMCC XR30 / CNIC XR30.
SDK CI builds IPK and APK variants for x86_64 and aarch64_generic.

Reviewed CONTRIBUTING.md. This PR contains no patches.

efahl · 2026-09-14T17:42:52Z

+if [ -z "$${IPKG_INSTROOT}" ]; then
+	rm -f /tmp/oph5spdtst/payload.bin /tmp/oph5spdtst/payload.bin.tmp
+	rm -f /www/luci-static/resources/oph5spdtst/downloading \
+	/www/luci-static/resources/oph5spdtst/downloading.tmp


Shouldn't this be in the luci-app- package?

There will later be a luci-app-oph5spdtst package coming (Currently simply only for install framed web + Configuration plane in web ui.). The intention here is to split test payload generation logic + pure test web resource from luci web since openwrt devices might have small/slow flash memory or other types of web service. Maybe I should couple this harder with luci since it requires luci path? I can integrate this logic into luci app if you say so.

efahl · 2026-09-14T17:43:04Z

+	$(INSTALL_DIR) $(1)/etc/init.d
+	$(INSTALL_BIN) ./files/oph5spdtst.init $(1)/etc/init.d/oph5spdtst
+
+	$(INSTALL_DIR) $(1)/www/luci-static/resources/oph5spdtst


Likewise, part of luci...

openwrt-ai

Commit checks

ed93798 "oph5spdtst: add package" — body has blank lines inserted mid-sentence ("... payload service from the" / "immutable v0.2.0 source release."); reflow it into one paragraph.

Generated by Claude Code

openwrt-ai · 2026-09-15T05:25:30Z

+stop() {
+	remove_payloads
+}


In flash mode $FILE_SRC_LINK_PATH is the real 5 MiB payload, not a symlink, and remove_payloads deletes it unconditionally — so every shutdown (STOP=10 runs the K link) and every restart wipes it and start() rewrites 5 MiB to flash on the next boot. That defeats use_flash_stored_payload and adds avoidable flash wear. Load the config in stop() and skip the flash file, or only unlink when [ -L "$FILE_SRC_LINK_PATH" ].

Generated by Claude Code

fixed, thanks

Generated by Claude Code

openwrt-ai · 2026-09-15T05:25:36Z

+PKG_SOURCE:=v$(PKG_VERSION).tar.gz
+PKG_SOURCE_URL:=https://github.com/AzulEterno/oph5spdtst/archive/refs/tags/


v0.2.0.tar.gz is a generic filename in the shared dl/ directory and collides with any other package fetching a v<version> GitHub tag archive. The feed's convention is $(PKG_NAME)-$(PKG_VERSION).tar.gz plus the codeload URL (244 Makefiles use codeload.github.com vs 10 using archive/refs/tags); the tarball bytes are the same, so PKG_HASH stays valid.

Suggested change

PKG_SOURCE:=v$(PKG_VERSION).tar.gz

PKG_SOURCE_URL:=https://github.com/AzulEterno/oph5spdtst/archive/refs/tags/

PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz

PKG_SOURCE_URL:=https://codeload.github.com/AzulEterno/oph5spdtst/tar.gz/v$(PKG_VERSION)?

Generated by Claude Code

solved by dropping the tarball download entirely, thanks

Generated by Claude Code

openwrt-ai · 2026-09-15T05:25:42Z

+PKG_LICENSE:=Apache-2.0 MIT
+PKG_LICENSE_FILES:=src/LICENSE src/www/luci-static/resources/oph5spdtst/License.md
+
+PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME)-$(PKG_VERSION)


nit: byte-for-byte the default from include/package.mk:11; drop the line.

Generated by Claude Code

fixed, thanks

Generated by Claude Code

openwrt-ai · 2026-09-15T05:25:48Z

+START=99
+STOP=10


Init scripts in this feed are expected to be procd-based: add USE_PROCD=1 and use start_service() / stop_service(). Even for a one-shot that buys you service_triggers, so editing /etc/config/oph5spdtst re-runs the payload setup instead of requiring a manual restart.

Generated by Claude Code

fixed, thanks

Generated by Claude Code

openwrt-ai · 2026-09-15T05:25:53Z

+
+	mkdir -p "$dir" || return 1
+	rm -f "$tmp"
+	dd if=/dev/urandom of="$tmp" bs="$FILE_SIZE" count=1 >/dev/null 2>&1 || {


nit: this is one 5 MiB read, and a short read from /dev/urandom still exits 0, so a truncated payload gets mv'd into place and only fails payload_is_valid on the next start. Use bs=1M count=5, or verify the size before the mv.

Generated by Claude Code

fixed, thanks

Generated by Claude Code

openwrt-ai · 2026-09-15T05:26:00Z

+		create_payload "$SPDTST_FILE_PATH" "$SPDTST_TMP_PATH" "$SPDTST_FILE_DIR" || return 1
+	fi
+
+	ln -s "$SPDTST_FILE_PATH" "$FILE_SRC_LINK_PATH"


With uhttpd's option no_symlinks 1 the request path goes through realpath() and is then rejected by the /* check whether found path is within docroot */ test in uhttpd's file.c, so this link resolves outside /www and the download 404s. Default config is unaffected — is that a documented limitation, or should the payload live under the docroot (bind mount / real file) instead?

Generated by Claude Code

Add the payload service and UCI configuration for the oph5spdtst web frontend. Web assets are installed by the separate LuCI package. Signed-off-by: Azul Eterno <jay2236419527@gmail.com>

openwrt-ai

Reviewed 1 new commit.

Generated by Claude Code

openwrt-ai · 2026-09-17T05:48:56Z

+	if ! payload_is_valid "$FILE_SRC_LINK_PATH"; then
+		create_payload "$FILE_SRC_LINK_PATH" "$FILE_SRC_TMP_PATH" "$FILE_SRC_DIR"
+	fi


create_payload's exit status is discarded, so a failed flash write leaves start_service returning 0 with no payload in place; the tmp branch at oph5spdtst.init:64 propagates it.

Suggested change

if ! payload_is_valid "$FILE_SRC_LINK_PATH"; then

create_payload "$FILE_SRC_LINK_PATH" "$FILE_SRC_TMP_PATH" "$FILE_SRC_DIR"

fi

if ! payload_is_valid "$FILE_SRC_LINK_PATH"; then

create_payload "$FILE_SRC_LINK_PATH" "$FILE_SRC_TMP_PATH" "$FILE_SRC_DIR" || return 1

fi

Generated by Claude Code

fixed, thanks

Generated by Claude Code

openwrt-ai · 2026-09-17T05:49:03Z

+FILE_SIZE_MB=5
+FILE_SIZE_BYTES=5242880


nit: two constants that have to be kept in sync by hand — change one and payload_is_valid rejects every payload forever, so each start rewrites the file. Derive the byte count instead.

Suggested change

FILE_SIZE_MB=5

FILE_SIZE_BYTES=5242880

FILE_SIZE_MB=5

FILE_SIZE_BYTES=$((FILE_SIZE_MB * 1024 * 1024))

Generated by Claude Code

fixed, thanks

Generated by Claude Code

openwrt-ai · 2026-09-17T05:49:09Z

+endef
+
+define Package/oph5spdtst/description
+  Provides a payload service for the oph5spdtst web frontend.


nit: the PR body still states the package "installs the web assets, UCI configuration, and payload service from the immutable v0.2.0 release" — neither the web assets nor the tarball download exist in this revision. Please bring the PR description in line with this description block.

Generated by Claude Code

solved by rewriting the PR description, thanks

Generated by Claude Code

Add the payload service and UCI configuration for the oph5spdtst web frontend. Web assets are installed by the separate LuCI package. Signed-off-by: Azul Eterno <jay2236419527@gmail.com>

openwrt-ai

Commit checks

111a660 "oph5spdtst: add package" — repeats 28b6767's full "add package" message but only tweaks two lines in oph5spdtst.init; squash it into 28b6767 so the package is added in a single commit.

Generated by Claude Code

openwrt Bot added Add package not following guidelines labels Sep 14, 2026

AzulEterno force-pushed the oph5spdtst-submission branch from 38704f0 to ed93798 Compare September 14, 2026 16:09

openwrt Bot removed the not following guidelines label Sep 14, 2026

efahl suggested changes Sep 14, 2026

View reviewed changes

openwrt-ai reviewed Sep 15, 2026

View reviewed changes

AzulEterno force-pushed the oph5spdtst-submission branch from ed93798 to 7b7cf5c Compare September 16, 2026 08:49

openwrt Bot added the not following guidelines label Sep 16, 2026

oph5spdtst: add package

28b6767

Add the payload service and UCI configuration for the oph5spdtst web frontend. Web assets are installed by the separate LuCI package. Signed-off-by: Azul Eterno <jay2236419527@gmail.com>

AzulEterno force-pushed the oph5spdtst-submission branch from 7b7cf5c to 28b6767 Compare September 16, 2026 09:02

openwrt Bot removed the not following guidelines label Sep 16, 2026

openwrt-ai reviewed Sep 17, 2026

View reviewed changes

oph5spdtst: add package

111a660

Add the payload service and UCI configuration for the oph5spdtst web frontend. Web assets are installed by the separate LuCI package. Signed-off-by: Azul Eterno <jay2236419527@gmail.com>

openwrt-ai reviewed Sep 19, 2026

View reviewed changes

		PKG_SOURCE:=v$(PKG_VERSION).tar.gz
		PKG_SOURCE_URL:=https://github.com/AzulEterno/oph5spdtst/archive/refs/tags/

		START=99
		STOP=10

Conversation

AzulEterno commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Package details

Testing

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openwrt-ai left a comment

Choose a reason for hiding this comment

Commit checks

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openwrt-ai left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openwrt-ai left a comment

Choose a reason for hiding this comment

Commit checks

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AzulEterno commented Sep 14, 2026 •

edited

Loading