Conversation
Formality Check: Suggestions AvailableWe checked this pull request against the contribution guidelines. Here is what needs your attention:
|
e9fc205 to
b6adc1a
Compare
Fixes openwrt#30387 Uses suggested fix from openwrt#30387 (comment) Signed-off-by: Martin Brodbeck <martin@brodbeck-online.de>
Co-authored-by: OpenWrt AI review account <openwrt-ai@hauke-m.de> Signed-off-by: Martin Brodbeck <martin@brodbeck-online.de>
Co-authored-by: OpenWrt AI review account <openwrt-ai@hauke-m.de> Signed-off-by: Martin Brodbeck <martin@brodbeck-online.de>
b6adc1a to
f73c532
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Commit checks
4eb2e6f"ddns-scripts: apply suggestion from @openwrt-ai" — subject describes the review workflow, not the change. Say what it does (e.g.ddns-scripts: fix typo in netcup comment), or fold it intoac80481.f73c532"ddns-scripts: apply suggestion from @openwrt-ai" — same; this one changes the record-match comparison to the new IP, which is the substance ofac80481and belongs squashed into it rather than as a follow-up with an unrelated subject.
Generated by Claude Code
| # compare ip's | ||
| __rec_cmp="$__rec_destination" | ||
| [ "$__RRTYPE" = "AAAA" ] && expand_ipv6 "$__rec_destination" __rec_cmp | ||
| if [ "$__rec_cmp" != "$__IP" ]; then |
There was a problem hiding this comment.
This was the last consumer of REGISTERED_IP, so the guard at update_netcup_com.sh:46 now aborts on a variable the script no longer reads — and write_log 14 exit 1s the whole updater. That kills the very first IPv4 update on a fresh setup, where get_registered_ip returns 127 and leaves REGISTERED_IP empty. Drop that line.
Generated by Claude Code
Fixes #30387
Uses suggested fix from #30387 (comment)
📦 Package Details
Maintainer: @feckert
(You can find this by checking the history of the package
Makefile.)Description:
Fixes #30387
Uses suggested fix from #30387 (comment)
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.