Skip to content

ddns-scripts: fix updating IPv6 for netcup - #30516

Open
beedaddy wants to merge 3 commits into
openwrt:masterfrom
beedaddy:fix_ipv6_ddns-update-netcup-com_improved
Open

beedaddy wants to merge 3 commits into
openwrt:masterfrom
beedaddy:fix_ipv6_ddns-update-netcup-com_improved

Conversation

@beedaddy

Copy link
Copy Markdown

Fixes #30387
Uses suggested fix from #30387 (comment)

📦 Package Details

Maintainer: @feckert
(You can find this by checking the history of the package Makefile.)

Description:

Fixes #30387
Uses suggested fix from #30387 (comment)

🧪 Run Testing Details

  • OpenWrt Version: 25.12.5
  • OpenWrt Target/Subtarget:
  • OpenWrt Device: GL.iNet Flint 2

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@openwrt

openwrt Bot commented Sep 13, 2026

Copy link
Copy Markdown

Formality Check: Suggestions Available

We checked this pull request against the contribution guidelines. Here is what needs your attention:

⚠️ STYLISTIC WARNINGS & SUGGESTIONS

Package Release Audit:

  • ⚠️ Content changed in these packages, but without a PKG_RELEASE or version bump:

    • net/ddns-scripts

    Increment PKG_RELEASE by 1 (or bump PKG_VERSION/PKG_SOURCE_DATE and reset PKG_RELEASE to 1) so users receive the update.

Do not increment release for minor changes. Cosmetic edits (e.g., typos in comments, copyright updates, formatting/whitespace), changing the package maintainer (PKG_MAINTAINER), or updating source download info (PKG_SOURCE_URL / PKG_HASH) do not require incrementing PKG_RELEASE.


Something broken? Consider reporting an issue.
Running version 059e3de deployed on 2026-09-09 11:53:18 CEST

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit.


Generated by Claude Code

Comment thread net/ddns-scripts/files/usr/lib/ddns/update_netcup_com.sh Outdated
Comment thread net/ddns-scripts/files/usr/lib/ddns/update_netcup_com.sh Outdated
@beedaddy
beedaddy force-pushed the fix_ipv6_ddns-update-netcup-com_improved branch from e9fc205 to b6adc1a Compare September 14, 2026 17:49
@beedaddy beedaddy changed the title Fix updating IPv6 for netcup ddns-scripts: Fix updating IPv6 for netcup Sep 14, 2026
beedaddy and others added 3 commits September 14, 2026 20:02
Fixes openwrt#30387
Uses suggested fix from openwrt#30387 (comment)

Signed-off-by: Martin Brodbeck <martin@brodbeck-online.de>
Co-authored-by: OpenWrt AI review account <openwrt-ai@hauke-m.de>
Signed-off-by: Martin Brodbeck <martin@brodbeck-online.de>
Co-authored-by: OpenWrt AI review account <openwrt-ai@hauke-m.de>
Signed-off-by: Martin Brodbeck <martin@brodbeck-online.de>
@beedaddy
beedaddy force-pushed the fix_ipv6_ddns-update-netcup-com_improved branch from b6adc1a to f73c532 Compare September 14, 2026 18:03
@beedaddy beedaddy changed the title ddns-scripts: Fix updating IPv6 for netcup ddns-scripts: fix updating IPv6 for netcup Sep 14, 2026

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit checks

  • 4eb2e6f "ddns-scripts: apply suggestion from @openwrt-ai" — subject describes the review workflow, not the change. Say what it does (e.g. ddns-scripts: fix typo in netcup comment), or fold it into ac80481.
  • f73c532 "ddns-scripts: apply suggestion from @openwrt-ai" — same; this one changes the record-match comparison to the new IP, which is the substance of ac80481 and belongs squashed into it rather than as a follow-up with an unrelated subject.

Generated by Claude Code

# compare ip's
__rec_cmp="$__rec_destination"
[ "$__RRTYPE" = "AAAA" ] && expand_ipv6 "$__rec_destination" __rec_cmp
if [ "$__rec_cmp" != "$__IP" ]; then

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the last consumer of REGISTERED_IP, so the guard at update_netcup_com.sh:46 now aborts on a variable the script no longer reads — and write_log 14 exit 1s the whole updater. That kills the very first IPv4 update on a fresh setup, where get_registered_ip returns 127 and leaves REGISTERED_IP empty. Drop that line.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ddns-scripts: ddns-update-netcup-com.sh is never updating ...

2 participants