Conversation
All patents seem to have expired between 2014-2020. Signed-off-by: Rosen Penev <rosenp@gmail.com>
| CATEGORY:=Libraries | ||
| TITLE:=DVB Common Scrambling Algorithm Library | ||
| URL:=https://www.videolan.org/developers/libdvbcsa.html | ||
| DEPENDS:=@BUILD_PATENTED |
There was a problem hiding this comment.
nit: the two in-tree consumers still gate libdvbcsa on the same symbol — +BUILD_PATENTED&&TVHEADEND_CSA:libdvbcsa with TVHEADEND_CSA itself depends on BUILD_PATENTED, and +BUILD_PATENTED:libdvbcsa plus its --enable-dvbcsa toggle. So CSA descrambling stays unreachable unless BUILD_PATENTED=y; is dropping those gates intended as a follow-up, or should it be part of this series?
Generated by Claude Code
There was a problem hiding this comment.
|
LGTM. Although, as bot noticed, other packages that conditionally add |
libdvbcsa no longer requires BUILD_PATENTED, so drop the gate from the libdvbcsa dependency and the configure args. Software descrambling is now enabled via TVHEADEND_CSA alone. Signed-off-by: Rosen Penev <rosenp@gmail.com>
libdvbcsa no longer requires BUILD_PATENTED, so enable dvbcsa unconditionally and drop the BUILD_PATENTED dependency and config toggle. Signed-off-by: Rosen Penev <rosenp@gmail.com>
| SECTION:=multimedia | ||
| CATEGORY:=Multimedia | ||
| DEPENDS:=+MINISATIP_AES:libopenssl +BUILD_PATENTED:libdvbcsa | ||
| DEPENDS:=+MINISATIP_AES:libopenssl +libdvbcsa |
There was a problem hiding this comment.
nit: libdvbcsa becomes a hard dependency for every minisatip install, while the sibling commit keeps it optional in tvheadend behind +TVHEADEND_CSA:libdvbcsa. The other two optional features here still have toggles in Package/minisatip/config; was dropping the opt-out for dvbcsa rather than converting it to a MINISATIP_DVBCSA symbol intentional?
Generated by Claude Code
3 participants
All patents seem to have expired between 2014-2020.
📦 Package Details
Maintainer: @Rafostar